Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hacktoberfest] ConfigMap fields may be 'final' #1797 #1805

Merged
merged 3 commits into from
Oct 12, 2022
Merged

[Hacktoberfest] ConfigMap fields may be 'final' #1797 #1805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df247d6
Update ConfigMap.java
ShubhraSuman Oct 9, 2022
c2c8ecf
Merge branch 'eclipse:master' into ConfigMapChange
ShubhraSuman Oct 10, 2022
9034c24
to be squashed
manusa Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jkube-kit/config/resource/src/main/java/org/eclipse/jkube/kit/config/resource/ConfigMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
public class ConfigMap {

private String name;
private List<ConfigMapEntry> entries = new ArrayList<>();
private final List<ConfigMapEntry> entries = new ArrayList<>();

public void addEntry(ConfigMapEntry configMapEntry) {
this.entries.add(configMapEntry);
Expand All @@ -31,7 +31,7 @@ public List<ConfigMapEntry> getEntries() {

/**
* Set the name of ConfigMap.
* @param name
* @param name the ConfigMap name
*/
public void setName(String name) {
this.name = name;
Expand Down