Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Template resolution and helm work in OpenShift-Maven-Plugin #306

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jul 21, 2020

Description

Fix: Template resolution and helm work in OpenShift-Maven-Plugin

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #306 into master will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #306      +/-   ##
============================================
+ Coverage     33.43%   33.50%   +0.06%     
- Complexity     2139     2141       +2     
============================================
  Files           364      364              
  Lines         18593    18561      -32     
  Branches       2746     2740       -6     
============================================
+ Hits           6216     6218       +2     
+ Misses        11647    11613      -34     
  Partials        730      730              
Impacted Files Coverage Δ Complexity Δ
...clipse/jkube/kit/common/util/KubernetesHelper.java 19.68% <ø> (+1.43%) 31.00 <0.00> (ø)
...se/jkube/maven/plugin/mojo/build/ResourceMojo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...clipse/jkube/maven/plugin/mojo/build/HelmMojo.java 72.89% <60.00%> (+0.51%) 23.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3a2dd...03ed981. Read the comment docs.

@rohanKanojia rohanKanojia merged commit 87bde68 into eclipse-jkube:master Jul 22, 2020
@manusa manusa deleted the fix/spring-boot-helm branch July 22, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants