Fixed Quarkus health paths

[dloiacono]

Description

The way the health path is builded for quarkus application is not correct.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• I have read the contributing guidelines
• I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
• I Added CHANGELOG entry
• I have implemented unit tests to cover my changes
• I have updated the documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[rohanKanojia]

I think you would need to modify tests too with respect to this change:

[ERROR]   QuarkusHealthCheckEnricherTest.createWithCustomPathInKubernetes:105 [Extracted: spec] 
Expecting:
  <[("HTTP", "/my-custom-path/live", "HTTP", "/my-custom-path/ready")]>
to contain exactly (and in same order):
  <[("HTTP", "/my-custom-path", "HTTP", "/my-custom-path")]>
but some elements were not found:
  <[("HTTP", "/my-custom-path", "HTTP", "/my-custom-path")]>
and others were not expected:
  <[("HTTP", "/my-custom-path/live", "HTTP", "/my-custom-path/ready")]>

[ERROR]   QuarkusHealthCheckEnricherTest.createWithDefaultsInKubernetes:86 [Extracted: spec] 
Expecting:
  <[("HTTP", "/health/live", "HTTP", "/health/ready")]>
to contain exactly (and in same order):
  <[("HTTP", "/health", "HTTP", "/health")]>
but some elements were not found:
  <[("HTTP", "/health", "HTTP", "/health")]>
and others were not expected:
  <[("HTTP", "/health/live", "HTTP", "/health/ready")]>

[codecov]

Codecov Report

Merging #579 (4a87c50) into 1.1.x (d8385d1) will increase coverage by 0.26%.
The diff coverage is 81.87%.

@@             Coverage Diff              @@
##              1.1.x     #579      +/-   ##
============================================
+ Coverage     42.04%   42.30%   +0.26%     
- Complexity     2840     2871      +31     
============================================
  Files           402      404       +2     
  Lines         19461    19473      +12     
  Branches       2777     2760      -17     
============================================
+ Hits           8183     8239      +56     
+ Misses        10287    10243      -44     
  Partials        991      991              

Impacted Files	Coverage Δ	Complexity Δ
...e/jkube/kit/build/service/docker/BuildService.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...ube/kit/build/service/docker/ContainerTracker.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...g/handler/compose/DockerComposeServiceWrapper.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...org/eclipse/jkube/kit/common/util/ProcessUtil.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...kube/kit/enricher/api/visitor/MetadataVisitor.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...ube/enricher/generic/openshift/ExposeEnricher.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...pse/jkube/maven/plugin/mojo/develop/WatchMojo.java	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...onfig/service/kubernetes/KubernetesClientUtil.java	18.64% <50.00%> (-6.36%)	11.00 <0.00> (-1.00)
.../kit/enricher/api/util/KubernetesResourceUtil.java	38.05% <50.00%> (+0.39%)	52.00 <2.00> (ø)
...eclipse/jkube/kit/config/service/ApplyService.java	19.09% <70.83%> (-0.84%)	51.00 <4.00> (-4.00)
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8385d1...4a87c50. Read the comment docs.

[manusa]

Related:

• https://quarkus.io/guides/microprofile-health#architecture
• Enricher for MicroProfile Health implementations #443
• "Duplicate value: http" error when it is declared in service.yml file #450 (comment)

[manusa]

Hi @dloiacono
We want to release 1.1.1 early next week.
If you want this to be part of that release, please create the commit on top of the 1.1.x branch.
On the other hand, if you fine with this being part of 1.2.0 (release date TBD), just let us know.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

82.5% Coverage
0.0% Duplication