Circular imports error between dialogs and widgets files

[ranndev]

Bug Description:

After upgrading from 1.52 to 1.54 some of our unit tests that import the ReactDialog started failing with TypeError: Class extends value undefined is not a constructor or null caused by a circular imports.

To Reproduce:

Create a unit test that will import the ReactDialog and run it:

Upon investigation, the ReactDialog imported the AbstractDialog. However, before the dialogs.ts defines the AbstractDialog, it needs to resolve the import from './widgets/index.ts' which imports packages/core/src/browser/widgets/split-widget.ts -> packages/core/src/browser/saveable.ts which requires the AbstractDialog too.

This can be fixed by changing the widgets import path in the dialogs.ts to './widgets/widget' where the types and methods are exactly located.

Additional Information

• Operating System: MacOS
• Theia Version: 1.54

[msujew]

Hey @ranndev,

thanks for looking into this. Do you mind providing a PR to fix this?

[ranndev]

@msujew I'll create a PR for this.