Fix circular imports when importing ReactDialog #14352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14347 Contributed on behalf of Toro Cloud Signed-off-by: Rannie Peralta <[email protected]>
Signed-off-by: Rannie Peralta <[email protected]>
JonasHelming
requested review from
sdirix,
msujew and
tsmaeder
and removed request for
sdirix and
msujew
Signed-off-by: Rannie Peralta <[email protected]>
rannp-toro-cloud
force-pushed
the
fix-circular-imports-when-importing-react-dialog
branch
from
e3bab7c to
d68b0ce
Compare
tsmaeder
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR changes the import path from dialogs.ts to a specific path where the required types and methods are located to fix the circular dependency error.
Fixes #14347
Contributed on behalf of Toro Cloud
How to test
I added a unit test (packages/core/src/browser/dialogs/react-dialog.spec.tsx) to verify this fix.
Follow-ups
Review checklist
Reminder for reviewers