Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] Addition of the read-only property id to ThemeColor #14404

Closed
Tracked by #14403
rschnekenbu opened this issue Nov 5, 2024 · 0 comments · Fixed by #14437
Closed
Tracked by #14403

[vscode] Addition of the read-only property id to ThemeColor #14404

rschnekenbu opened this issue Nov 5, 2024 · 0 comments · Fixed by #14437
Assignees
@rschnekenbu
Labels
vscode issues related to VSCode compatibility

Comments

@rschnekenbu
Copy link
Contributor

ThemeColor constructor was already having an id parameter. It is now accessible as a readonly property.
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Nov 5, 2024
@rschnekenbu rschnekenbu self-assigned this Nov 5, 2024
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 12, 2024
@rschnekenbu
feat: support property ThemeColor id
b1dff88 
fix eclipse-theia#14404

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 12, 2024
@rschnekenbu
feat: support readonly property ThemeColor id
74c1d61 
fix eclipse-theia#14404

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
This was referenced Nov 12, 2024
Merged
Closed
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Nov 14, 2024
@rschnekenbu
feat: support readonly property ThemeColor id
a27083d 
fix eclipse-theia#14404

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschnekenbu rschnekenbu

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support property ThemeColor id eclipsesource/theia
1 participant
@rschnekenbu