feat: support property ThemeColor id #14437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix eclipse-theia#14404 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
force-pushed
the
issues/14404
branch
from
74c1d61
to
a27083d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds the ThemeColor#id readonly property. This was already available as a parameter in the constructor of ThemeColor.
It also forces the id to be readonly in Theia implementations of ThemeColor.
fix #14404
How to test
Test: Show Theme Colorthat opens a QuickInput dialog to ask for a ThemeColor id. When entered, a message is displayed as a notification and a text is also displayed for a short period of time in the status bar, with the given theme color.Follow-ups
None
Review checklist
Reminder for reviewers