Wait for plugins to deploy before restoring the current language

[AlbyIanna]

What it does

Wait for the plugins to be deployed before restoring the current language.

Fixes #11471

How to test

• Open IDE select de as the default
• IDE reloads, it shows de
• Quit IDE
• Start IDE, it still shows de ✅
• Select zh-cn as the default language
• IDE reloads and shows zh-cn ✅
• Quit IDE
• Open IDE
• The language is still zh-cn ✅

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

Thank you for your contribution 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

Please also be sure to properly fill out the original pull-request template.

[msujew]

I'm not sure that this is the right way to go about this, since it doesn't actually resolve the issue. When getting all available languages, including those which don't have language packs loaded, we will definitely have to deal with the problem of 90% of Theia not being translated.

As far as I can tell this is a race condition, right? So instead, the express endpoint should await the plugin loading process, where all language packs are loaded into memory. This should be done fairly quickly without impacting the load time on Electron.

I can probably contribute a fix for this within the next few days.

[AlbyIanna]

we will definitely have to deal with the problem of 90% of Theia not being translated.

This would be true only during the loading time, right?

But yes, I would go for the other solution too, I just couldn't find a way to await for the languages loading process. Probably I've just didn't dig deep enough (and also didn't know how waiting for it would affect the Theia loading time)

[msujew]

This would be true only during the loading time, right?

Yes, but that's the issue. We already load translations during loading time. The /i18n/:locale endpoint not only returns metadata on languages, but all of the translations as well, since they need to be available at the time of loading the JS code.

[AlbyIanna]

@msujew I see. Thanks for the tip, I think I've found a better solution here

if you like it, I'd gladly update this PR with that code.

[msujew]

@AlbyIanna Sure, something similar should work for the Theia codebase as well 👍

Don't forget to sign the ECA by the way.

[AlbyIanna]

@msujew done 👌

[msujew]

@AlbyIanna With "something similar" I didn't mean the exact same approach ;) Given our architecture, you can't simply import code from the plugin-ext package into the core package. You'll have to create a dedicated override in the plugin-ext package for the LocalizationBackendContribution and bind it there.

Also we can't accept your changes when you haven't signed the ECA. Please do so.

[AlbyIanna]

You'll have to create a dedicated override in the plugin-ext package for the LocalizationBackendContribution and bind it there.

@msujew I'm not sure how to proceed here. Could you please provide me with an example of how to do that?

Also we can't accept your changes when you haven't signed the ECA. Please do so.

I should have done it now. Can you please confirm I did it right?

[msujew]

I'm not sure how to proceed here. Could you please provide me with an example of how to do that?

Sure, I recently did something similar: There is a core LanguageQuickPickService, which is overriden in the vsx-registry package as VSXLanguageQuickPickService as the services in there aren't available in core.

I should have done it now. Can you please confirm I did it right?

Are you sure you did it with the mail that's in the commit? It doesn't seem to validate.

[AlbyIanna]

Are you sure you did it with the mail that's in the commit? It doesn't seem to validate.

Yes, I'm sure about it because I received the confirmation e-mail after the registration.

This is what I see in my Eclipse Account:

[msujew]

Yes, I'm sure about it because I received the confirmation e-mail after the registration.

Alright, cool. It seems to work now. No idea why it didn't work previously.

[msujew]

There are a few linting errors across the changes. You should probably enable the ESLint vscode extension so you can catch those during development.

[AlbyIanna]

@msujew thanks for the feedback. In the last commit I've made some changes according to your requests 👍

[msujew]

Great, just one change and this should be good to go 👍

Also, just for completeness' sake, do you mind filling out the PR template?

[msujew]

@AlbyIanna Are you still interested in contributing the changes? I still have a few outstanding comments before approving this.

[AlbyIanna]

Hi @msujew, thanks for the review. Sorry for the delay in answering, I must have missed the notification 🙏
I will address your remarks soon.

[msujew]

The changes look good to me 👍

Please address the linting issues (see below) and then I'll merge this.