Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/ux: styling vsx and source control input fields #12604

Merged
merged 7 commits into from
Jun 14, 2023

Conversation

vladarama
Copy link
Contributor

What it does

Closes: #10855
This PR provides better styling for various input fields when the view is limited. This includes the vsx-registry and the source control views. These changes allow the placeholder overflow to be hidden and replaced by an ellipsis to make the styling cleaner and more consistent.

Demo:
VSX Styling Demo

How to test

  • Start Theia, open the Extensions or the Source Control views
  • Resize the view, making it smaller
  • The input field should be responsive, with the text overflow hidden by an ellipsis

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Jun 9, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
The changes work well for me, and I can confirm the input fields are more responsive.

@vince-fugnitto
Copy link
Member

@vladarama when you have the time do you mind rebasing to resolve the conflicts, and I'll merge.

@vince-fugnitto vince-fugnitto merged commit 7c230ec into eclipse-theia:master Jun 14, 2023
@vince-fugnitto vince-fugnitto added this to the 1.39.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

vsx-registry: better styling for extensions-view search field
2 participants