Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/ux: fix bug induced by PR #12604 #12622

Merged
merged 9 commits into from
Jun 14, 2023

Conversation

vladarama
Copy link
Contributor

What it does

This PR fixes a bug that was induced in #12604 where the styling for input fields would not be displayed properly. An example would be the input field appearing when renaming a file. This was caused by overflow: hidden being applied on all text-inputs. Now, the overflow: hidden will only be applied to the vsx-extension-search-bar which requires it.

Before:
image

After:
image

How to test

  1. Start Theia, open the Extensions or the Source Control views
  2. Resize the view, making it smaller
  3. The input field should be responsive, with the text overflow hidden by an ellipsis
  4. Try renaming a file, the input field should be styled correctly

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the ui/ux issues related to user interface / user experience label Jun 14, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the bug on master, and that this change successfully fixes it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants