Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialogs - Allow multiple selection on Open... #12923

Merged
merged 1 commit into from
Sep 28, 2023
Merged

dialogs - Allow multiple selection on Open... #12923

merged 1 commit into from
Sep 28, 2023

Commits on Sep 28, 2023

  1. dialogs - Allow multiple selection on Open... 

    fixes eclipse-theia#12905

- allow multiple selection in doOpen dialog
- handle an array or a single URI or undefined when closing dialog

Contributed on behalf of ST Microelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>

Address review comments

- remove checks for files against workspace URI
- update variable name to a more representative one
- Simplify algorithm for single selected URI case
- update signatures to indicate an array of files or folders can be opened rather than a single element
    @rschnekenbu
    rschnekenbu committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6ee97b3 View commit details
    Browse the repository at this point in the history