Support string argument in vscode.open
#12997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| execute: async (resource: URI, columnOrOptions?: ViewColumn | TextDocumentShowOptions) => { | ||
| execute: async (resource: URI | string, columnOrOptions?: ViewColumn | TextDocumentShowOptions) => { | ||
| if (typeof resource === 'string') { | ||
| resource = URI.parse(resource); |
There was a problem hiding this comment.
What happens, if the String does not parse into a URL? In case a URI is not openable, we have logging below, does this alos work for a malformed URI passed in as a String?
There was a problem hiding this comment.
URI.parse never throws, the URI will just be relatively useless. So we should be good in that regard. AFAIK vscode also doesn't validate the input when parsing from a string.
|
This might be related to #12821 @AlexandraBuzila |
JonasHelming
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12996
How to test
Review checklist
Reminder for reviewers