Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support property ThemeColor id #14437

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat: support property ThemeColor id #14437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

<!-- ## 1.56.0 - not yet released -->

- [plugin] added support for ThemeColor property id [#14437](https://github.com/eclipse-theia/theia/pull/14437) - Contributed on behalf of STMicroelectronics

## 1.55.0 - 10/31/2024

- [ai] added logic to allow to order and clear AI History view [#14233](https://github.com/eclipse-theia/theia/pull/14233)
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/common/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export interface ThemeChangeEvent {
}

export interface ThemeColor {
id: string;
readonly id: string;
}

export interface ThemeIcon {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-ext/src/plugin/types-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ export class SnippetString {

@es5ClassCompat
export class ThemeColor {
constructor(public id: string) { }
constructor(public readonly id: string) { }
}

@es5ClassCompat
Expand Down
5 changes: 5 additions & 0 deletions packages/plugin/src/theia.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2696,6 +2696,11 @@ export module '@theia/plugin' {
* Using a theme color is preferred over a custom color as it gives theme authors and users the possibility to change the color.
*/
export class ThemeColor {
/**
* The id of this color.
*/
readonly id: string;

/**
* Creates a reference to a theme color.
*/
Expand Down
Loading