Inline: Skip explicit intrinsics when inlining stmt functions #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused issue when the following lines attempt to touch the non-existent procedure definition.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/461/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 221 221
Lines 41360 41360
=======================================
+ Hits 38587 38588 +1
+ Misses 2773 2772 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
approved these changes
Dec 18, 2024
Co-authored-by: Balthasar Reuter <[email protected]>
reuterbal
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stmt function inliner does not actually test the case where the stmt function contains calls to intrinsics. This PR remedies this and fixes the corner case by including explicitly marked intrinsic calls in the skip condition.
This caused issue when the following lines attempt to touch the non-existent procedure definition.