feat: Use v2 of the Datadog Profiler stack. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the newer version might be more efficient, so we should switch to using it. edx/edx-arch-experiments#749
timmc-edx
reviewed
Nov 12, 2024
| @@ -29,6 +29,7 @@ export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false | |||
| # We want to be able to toggle this on separately from DD in general. | |||
| {% if EDXAPP_DATADOG_PROFILING_ENABLE %} | |||
| export DD_PROFILING_ENABLED=true | |||
| export DD_PROFILING_STACK_V2_ENABLED=true | |||
There was a problem hiding this comment.
So it looks like there's DD_PROFILING_STACK_ENABLED which defaults to true, and this one defaults to false. I guess this means that stack collection is a normal part of profiling, and this would change us to a v2 of that stack collection.
timmc-edx
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the newer version might be more efficient, so we should switch to using it.
edx/edx-arch-experiments#749
Make sure that the following steps are done before merging: