Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use v2 of the Datadog Profiler stack. #100

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: Use v2 of the Datadog Profiler stack. #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions playbooks/roles/edxapp/templates/edx/app/edxapp/cms.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false
# We want to be able to toggle this on separately from DD in general.
{% if EDXAPP_DATADOG_PROFILING_ENABLE %}
export DD_PROFILING_ENABLED=true
export DD_PROFILING_STACK_V2_ENABLED=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like there's DD_PROFILING_STACK_ENABLED which defaults to true, and this one defaults to false. I guess this means that stack collection is a normal part of profiling, and this would change us to a v2 of that stack collection.

{% endif -%}

export PORT="{{ edxapp_cms_gunicorn_port }}"
Expand Down
1 change: 1 addition & 0 deletions playbooks/roles/edxapp/templates/edx/app/edxapp/lms.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false
# We want to be able to toggle this on separately from DD in general.
{% if EDXAPP_DATADOG_PROFILING_ENABLE %}
export DD_PROFILING_ENABLED=true
export DD_PROFILING_STACK_V2_ENABLED=true
{% endif -%}

export PORT="{{ edxapp_lms_gunicorn_port }}"
Expand Down
Loading