Skip to content

Commit

Permalink
chore(deps-dev): bump undici from 6.21.0 to 7.0.0 (#4336)
Browse files Browse the repository at this point in the history
  • Loading branch information
dependabot[bot] authored Dec 4, 2024
1 parent 408063b commit 21d3404
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 11 deletions.
5 changes: 5 additions & 0 deletions .tav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,11 @@ aws-sdk:
# - In [email protected] the `request.origin` property was added, which we need
# in the 'undici:request:create' diagnostic message.
undici:
- versions:
mode: max-7
include: '>=7.0.0 <8'
node: '>=20.18.1'
commands: node test/instrumentation/modules/undici/undici.test.js
- versions:
mode: max-7
include: '>=6.0.0 <7'
Expand Down
2 changes: 1 addition & 1 deletion docs/supported-technologies.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ so those should be supported as well.
|https://www.npmjs.com/package/pg[pg] |>=4.0.0 <9.0.0 |Will instrument all queries
|https://www.npmjs.com/package/redis[redis] |>=2.0.0 <5.0.0 |Will instrument all queries
|https://www.npmjs.com/package/tedious[tedious] |>=1.9 <20.0.0 | (Excluding v4.0.0.) Will instrument all queries
|https://www.npmjs.com/package/undici[undici] | >=4.7.1 <6 | Will instrument undici HTTP requests, except HTTP CONNECT. Requires node v14.17.0 or later, or the user to have installed the https://www.npmjs.com/package/diagnostics_channel['diagnostics_channel' polyfill].
|https://www.npmjs.com/package/undici[undici] | >=4.7.1 <8 | Will instrument undici HTTP requests, except HTTP CONNECT. Requires node v14.17.0 or later, or the user to have installed the https://www.npmjs.com/package/diagnostics_channel['diagnostics_channel' polyfill].
|https://www.npmjs.com/package/ws[ws] |>=1.0.0 <8.0.0 |Will instrument outgoing WebSocket messages
|https://www.npmjs.com/package/kafkajs[kafkajs] |>=2.0.0 <3.0.0 |Will instrument all send methods for producers and message and batch processing for consumers.
|=======================================================================
Expand Down
31 changes: 23 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
"thunky": "^1.1.0",
"tree-kill": "^1.2.2",
"typescript": "^5.0.2",
"undici": "^6.2.1",
"undici": "^7.0.0",
"vasync": "^2.2.0",
"wait-on": "^8.0.0",
"ws": "^7.2.1"
Expand Down
8 changes: 7 additions & 1 deletion test/_is_undici_incompat.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ function isUndiciIncompat() {
const undiciVer = require('undici/package.json').version;
const msg = `undici@${undiciVer} is incompatible with node@${nodeVer}`;

if (satisfies(undiciVer, '>=6.13.0') && satisfies(nodeVer, '<18.17.0')) {
if (satisfies(undiciVer, '>=7.0.0') && satisfies(nodeVer, '<20.18.1')) {
// https://github.com/nodejs/undici/pull/3880
return msg;
} else if (
satisfies(undiciVer, '>=6.13.0') &&
satisfies(nodeVer, '<18.17.0')
) {
// See discussion at https://github.com/nodejs/undici/issues/3123
return msg;
} else if (satisfies(undiciVer, '>=6.0.0') && satisfies(nodeVer, '<18.0.0')) {
Expand Down

0 comments on commit 21d3404

Please sign in to comment.