Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump undici from 6.21.0 to 7.0.0 #4336

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2024

Bumps undici from 6.21.0 to 7.0.0.

Release notes

Sourced from undici's releases.

v7.0.0

What's Changed

... (truncated)

Commits
  • 1cfe094 Bumped v7.0.0
  • 68a0d60 Bumped v7.0.0-alpha.10
  • c178ca1 Correctly parse JSON contentType in responseError interceptor (#3892)
  • 513e213 feat: add support for Timeout and Trailers (#3854)
  • ed1da80 Bumped v7.0.0-alpha.9
  • 3c67a3d Make the responseError interceptor backward compatible, add a body property (...
  • de6aea6 fix: response error interceptor broken (#3805)
  • 20fd58c fix: cache rm unused branch (#3889)
  • d006e90 fix: port retry to new hooks (#3883)
  • 3029bd8 fix: move statusMessage as optional arg in end (#3886)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 2, 2024
@dependabot dependabot bot requested a review from a team December 2, 2024 00:28
Bumps [undici](https://github.com/nodejs/undici) from 6.21.0 to 7.0.0.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.21.0...v7.0.0)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/undici-7.0.0 branch from afd7842 to 789413b Compare December 2, 2024 09:02
@david-luna david-luna requested a review from trentm December 2, 2024 15:16
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an update to .tav.yml as well, right?

@@ -29,7 +29,13 @@ function isUndiciIncompat() {
const undiciVer = require('undici/package.json').version;
const msg = `undici@${undiciVer} is incompatible with node@${nodeVer}`;

if (satisfies(undiciVer, '>=6.13.0') && satisfies(nodeVer, '<18.17.0')) {
if (satisfies(undiciVer, '>=7.0.0') && satisfies(nodeVer, '<20.18.1')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know the min-supported Node is 20.18.1 and not some other Node v20 version?
... ah, I see the update to their engines. I guess that is their prerogative, though I think that is pretty harsh for users.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... though I think that is pretty harsh for users.

I agree. At 1st I thought there might be a plan to use a feature which requires that version but I haven't found any clue about it. so I guess basically encouraging users to update nodejs I guess

@david-luna
Copy link
Member

There should be an update to .tav.yml as well, right?

You're right!

@david-luna david-luna merged commit 21d3404 into main Dec 4, 2024
18 checks passed
@david-luna david-luna deleted the dependabot/npm_and_yarn/undici-7.0.0 branch December 4, 2024 16:49
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants