Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Move expensive role building off transport thread (#113020) #113435

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Sep 24, 2024

Backports the following commits to 8.x:

This PR moves role building off the transport thread to the generic
thread pool, since role building can be expensive depending on role
structure. 

Role building is CPU bound so this PR uses a `ThrottledTaskRunner` to
limit the number of concurrent requests. I will explore adding a max
queue limit in a follow up. 

Resolves: ES-9505
@n1v0lg n1v0lg added :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Security Meta label for security team labels Sep 24, 2024
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Nov 19, 2024

@elasticmachine update branch

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Nov 19, 2024

@elasticmachine update branch

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Nov 20, 2024

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit cf880b6 into elastic:8.x Nov 20, 2024
20 checks passed
@n1v0lg n1v0lg deleted the backport/8.x/pr-113020 branch November 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants