Skip to content
This repository has been archived by the owner on Jan 2, 2025. It is now read-only.

test_destroy_unverified_incremental is broken on XFS on Ununtu 22.04 #138

Closed
e-kov opened this issue Jun 14, 2022 · 2 comments · Fixed by #148
Closed

test_destroy_unverified_incremental is broken on XFS on Ununtu 22.04 #138

e-kov opened this issue Jun 14, 2022 · 2 comments · Fixed by #148
Labels
bug Something isn't working project/data-plane

Comments

@e-kov
Copy link
Collaborator

e-kov commented Jun 14, 2022 •
edited
Loading 

elastio-snap: 
kernel: 5.15.0-35-generic
filesystem: xfs
gcc: 11.2.0-19ubuntu1)
bash: 5.1.16(1)-release
python: Python 3.10.4
test_destroy_active_incremental (test_destroy.TestDestroy) ... ok
test_destroy_active_snapshot (test_destroy.TestDestroy) ... ok
test_destroy_dormant_incremental (test_destroy.TestDestroy) ... ok
test_destroy_dormant_snapshot (test_destroy.TestDestroy) ... ok
test_destroy_nonexistent_device (test_destroy.TestDestroy) ... ok
test_destroy_unverified_incremental (test_destroy.TestDestroy) ... umount: /tmp/elastio-snap_798: target is busy.
ERROR
test_destroy_unverified_snapshot (test_destroy.TestDestroy) ... ok
test_setup_2_volumes (test_setup.TestSetup) ... ok
test_setup_already_tracked_volume (test_setup.TestSetup) ... ok
test_setup_cow_file_path_is_dir (test_setup.TestSetup) ... ok
test_setup_invalid_minor (test_setup.TestSetup) ... ok
test_setup_readonly_volume (test_setup.TestSetup) ... ok
test_setup_unmounted_volume (test_setup.TestSetup) ... ok
test_setup_volume (test_setup.TestSetup) ... ok
test_setup_volume_path_is_dir (test_setup.TestSetup) ... ok
test_modify_origin (test_snapshot.TestSnapshot) ... ok
test_next_available_minor (test_snapshot.TestSnapshot) ... ok
test_track_writes (test_snapshot.TestSnapshot) ... skipped 'Broken on XFS, due to ignored os.sync and due to #63.'
test_transition_active_incremental (test_transition_incremental.TestTransitionToIncremental) ... ok
test_transition_active_snapshot (test_transition_incremental.TestTransitionToIncremental) ... ok
test_transition_fs_sync_cow_full (test_transition_incremental.TestTransitionToIncremental) ... ok
test_transition_mod_sync_cow_full (test_transition_incremental.TestTransitionToIncremental) ... skipped 'Kernel flushed before module'
test_transition_nonexistent_snapshot (test_transition_incremental.TestTransitionToIncremental) ... ok
======================================================================
ERROR: test_destroy_unverified_incremental (test_destroy.TestDestroy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/elastio/elastio-snap/tests/test_destroy.py", line 76, in test_destroy_unverified_incremental
    util.unmount(self.mount)
  File "/home/elastio/elastio-snap/tests/util.py", line 23, in unmount
    subprocess.check_call(cmd, timeout=10)
  File "/usr/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['umount', '/tmp/elastio-snap_798']' returned non-zero exit status 32.
----------------------------------------------------------------------
Ran 23 tests in 7.483s
FAILED (errors=1, skipped=2)
Error: Process completed with exit code 1.

The same "target is busy" error is happening on test_destroy_unverified_snapshot.
@e-kov e-kov added bug Something isn't working project/data-plane labels Jun 14, 2022
@e-kov e-kov mentioned this issue Jun 14, 2022
Merged
e-kov pushed a commit that referenced this issue Jun 15, 2022
Modify tests to cover ext2/3/4, XFS filesystems (#137)
f61bdc5 
This modification for the tests was done long time ago in scope of draft for #63
It allows to run `tests/elio-test.sh` with the file system specified as an argument.
Now tests can be executed like this
```bash
# Run tests, as usually, on the loop device and ext4 filesystem
sudo ./elio-test.sh

# Run tests on the loop device and ext3 filesystem
sudo ./elio-test.sh -f ext3

# Run tests on the /dev/vdb1 device and XFS filesystem
sudo ./elio-test.sh -d /dev/vdb1 -f xfs
```

The test `test_track_writes` is disabled for XFS due to #63.
And all the tests for XFS were disabled on Debian 8 due to the mount issue
(created new bug #139) and on Ubuntu 22.04 due to the issue with destroy
of unverified snapshot and incremental (see new bug #138).
@anelson
Copy link

anelson commented Jun 26, 2022

@e-kov what does this test failure tell us about block backup support on XFS on Ubuntu 22.04? It's totally broken, or broken in some particular case? It's broken in the sense that a backup can fail, or it can succeed but with silent data corruption?

@anelson
Copy link

anelson commented Jun 27, 2022

Discussed on planning. Not clear what "unverified" means here but it doesn't appear to be a sign of a critical issue that will impact customers running Ubuntu 22.04

@skypodolsky skypodolsky mentioned this issue Jul 21, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working project/data-plane
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patch to fix [almost] all xfs problems elastio/elastio-snap
2 participants
@anelson @e-kov