This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
Modify tests to cover ext2/3/4, XFS filesystems #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2022 16:23
This modification for the tests was done long time ago in scope of draft for #63 It allows to run `tests/elio-test.sh` with the file system specified as an argument. Now tests can be executed like this ```bash sudo ./elio-test.sh sudo ./elio-test.sh -f ext3 sudo ./elio-test.sh -d /dev/vdb1 -f xfs ``` The test `test_track_writes` is disabled for XFS due to #63. And all the tests for XFS were disabled on Debian 8 due to some mount issue which is a part of issue #63 too.
e-kov
force-pushed
the
feat/different-fs-tests
branch
from
d3baad4 to
aa23480
Compare
e-kov
force-pushed
the
feat/different-fs-tests
branch
from
aa23480 to
c72104e
Compare
anelson
approved these changes
Jun 15, 2022
skypodolsky
reviewed
Jun 15, 2022
tests/devicetestcase.py
Outdated
| @@ -33,7 +33,8 @@ def setUpClass(cls): | |||
| util.dd("/dev/zero", cls.backing_store, 256, bs="1M") | |||
| cls.device = util.loop_create(cls.backing_store) | |||
|
|
|||
| util.mkfs(cls.device) | |||
| cls.fs = os.getenv('TEST_FS') if os.getenv('TEST_FS') else "ext4" | |||
There was a problem hiding this comment.
I'd suggest using the default value in the os.getenv() method
vsazhenyuk-softheme
approved these changes
Jun 15, 2022
skypodolsky
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification for the tests was done long time ago in scope of draft for #63
It allows to run
tests/elio-test.shwith the file system specified as an argument.Now tests can be executed like this
The test
test_track_writesis disabled for XFS due to #63.And all the tests for XFS were disabled on Debian 8 due to the mount issue
(created new bug #139) and on Ubuntu 22.04 due to the issue with destroy
of unverified snapshot and incremental (see new bug #138).
I need to get it landed, because I'm going to extend tests with the LVM and RAID devices.