Skip to content

Commit

Permalink
fix(puppets): added wait until networkidle opt for remote html input
Browse files Browse the repository at this point in the history
Added wait until networkidle0 option for loading a remote html input to prevent race conditions of
loading the input and taking the screenshots

fix #125
  • Loading branch information
onderceylan committed Jan 21, 2020
1 parent 45942e9 commit c41196e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/helpers/puppets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ const saveImages = async (
await page.setViewport({ width, height });

if (address) {
await page.goto(address);
await page.goto(address, { waitUntil: 'networkidle0' });
} else {
await page.setContent(shellHtml);
}
Expand Down

0 comments on commit c41196e

Please sign in to comment.