Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote html input doesn't load on windows all the time #125

Closed
onderceylan opened this issue Jan 21, 2020 · 1 comment · Fixed by #126
Closed

Remote html input doesn't load on windows all the time #125

onderceylan opened this issue Jan 21, 2020 · 1 comment · Fixed by #126
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@onderceylan
Copy link
Collaborator

I bump into a flaky test running on windows time to time: https://github.com/onderceylan/pwa-asset-generator/pull/123/checks?check_run_id=400204904#step:8:17

It's a sign that there might be an issue about race condition with loading the remote input and taking the screenshot.
@onderceylan onderceylan added the bug Something isn't working label Jan 21, 2020
@onderceylan onderceylan self-assigned this Jan 21, 2020
onderceylan added a commit that referenced this issue Jan 21, 2020
@onderceylan
fix(puppets): added wait until networkidle opt for remote html input
c41196e 
Added wait until networkidle0 option for loading a remote html input to prevent race conditions of
loading the input and taking the screenshots

fix #125
@onderceylan onderceylan mentioned this issue Jan 21, 2020
Merged
onderceylan added a commit that referenced this issue Jan 21, 2020
@onderceylan
fix(puppets): added wait until networkidle opt for remote html input
9aa86eb 
Added wait until networkidle0 option for loading a remote html input to prevent race conditions of
loading the input and taking the screenshots

fix #125
onderceylan pushed a commit that referenced this issue Jan 21, 2020
@semantic-release-bot
chore(release): 2.2.1 [skip ci]
07065a6 
## [2.2.1](v2.2.0...v2.2.1) (2020-01-21)

### Bug Fixes

* **puppets:** added wait until networkidle opt for remote html input ([9aa86eb](9aa86eb)), closes [#125](#125)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(puppets): added wait until networkidle opt for remote html input elegantapp/pwa-asset-generator
1 participant
@onderceylan