Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding type "jpg" #116

Closed
Sideral-Inc opened this issue Jan 16, 2020 · 5 comments · Fixed by #117
Closed

Adding type "jpg" #116

Sideral-Inc opened this issue Jan 16, 2020 · 5 comments · Fixed by #117
Assignees
@onderceylan
Labels
feature request New feature or request

Comments

@Sideral-Inc
Copy link

Would it be possible to add "jpg" as type as well.

It's not a big issue but I usually always use ".jpg" extension and not ".jpeg".
@Sideral-Inc Sideral-Inc added the feature request New feature or request label Jan 16, 2020
@onderceylan
Copy link
Collaborator

Hi @Sideral-Inc, thanks for the issue. Can you please elaborate on this? What would be the added value if the images have .jpg extension instead of .jpeg?

@Sideral-Inc
Copy link
Author

Hi @onderceylan,

Actually, I have some external automated tools that are configured to find and manipulate file with extension ".jpg".

Actually, it is more a "nice to have" feature / suggestion and asked it because I think it shouldn't add too much effort to add it.

@onderceylan
Copy link
Collaborator

Thanks for more information about your use case. I'll have a look at it soon :)

@onderceylan onderceylan self-assigned this Jan 16, 2020
onderceylan added a commit that referenced this issue Jan 16, 2020
@onderceylan
feat(main): added jpg extension as an output type
dba5599 
Added jpg extension in addition to jpeg as an output type

fix #116
@onderceylan onderceylan mentioned this issue Jan 16, 2020
Merged
onderceylan added a commit that referenced this issue Jan 16, 2020
@onderceylan
feat(main): added jpg extension as an output type
e1f2221 
Added jpg extension in addition to jpeg as an output type

fix #116
@onderceylan onderceylan reopened this Jan 16, 2020
@onderceylan
Copy link
Collaborator

Hold due to: semantic-release/git#187

onderceylan pushed a commit that referenced this issue Jan 16, 2020
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
07ac820 
# [2.2.0](v2.1.3...v2.2.0) (2020-01-16)

### Features

* **main:** added jpg extension as an output type ([e1f2221](e1f2221)), closes [#116](#116)
@onderceylan
Copy link
Collaborator

Published this feature with [email protected]!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(main): added jpg extension as an output type elegantapp/pwa-asset-generator
2 participants
@onderceylan @Sideral-Inc