Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): added jpg extension as an output type #117

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

onderceylan
Copy link
Collaborator

Added jpg extension in addition to jpeg as an output type

fix #116

Added jpg extension in addition to jpeg as an output type

fix #116
@onderceylan onderceylan requested a review from ofcyln January 16, 2020 16:01
@@ -278,7 +278,6 @@ const saveImages = async (
await page.screenshot({
path,
omitBackground: !options.opaque,
type: options.type,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice

Copy link
Collaborator

@ofcyln ofcyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go bro!

@onderceylan onderceylan merged commit e1f2221 into master Jan 16, 2020
@onderceylan onderceylan deleted the add-jpg-extension branch January 16, 2020 16:21
@onderceylan
Copy link
Collaborator Author

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding type "jpg"
2 participants