Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide specific image path for html output #148

Closed
pixeline opened this issue Jan 31, 2020 · 2 comments · Fixed by #183
Closed

Provide specific image path for html output #148

pixeline opened this issue Jan 31, 2020 · 2 comments · Fixed by #183
Assignees
@onderceylan
Labels
feature request New feature or request released

Comments

@pixeline
Copy link

I'm working on a Sapper/Svelte PWA.
The images are to sit in a "static/images/app-icons" folder.
Sapper uses a template.html static html file to generate the SPA index.html
If i do

pwa-asset-generator mathr-icon.png ./static/images/app-icons -o false -m static/site.webmanifest -i src/template.html -f true

The image path is of the like:

<link rel="apple-touch-icon" sizes="120x120" href="../static/images/app-icons/apple-icon-120.png">

Where it should be

<link rel="apple-touch-icon" sizes="120x120" href="./images/app-icons/apple-icon-120.png">

Describe the solution you'd like
I would like an additional parameter, for example: iff (for Images Folder Href) to set the path to use in the html generation.
@pixeline pixeline added the feature request New feature or request label Jan 31, 2020
@onderceylan
Copy link
Collaborator

Hi @pixeline, thanks for the issue. This makes sense, it can make the lib more flexible for the expected output. I will have a look at it soon.

@onderceylan onderceylan added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 9, 2020
@onderceylan onderceylan self-assigned this Mar 5, 2020
@onderceylan onderceylan removed good first issue Good for newcomers help wanted Extra attention is needed labels Mar 5, 2020
onderceylan added a commit that referenced this issue Mar 5, 2020
@onderceylan
feat(main): added pathOverride option to allow path optimisation on href
2d89cba 
Added pathOverride option to allow path optimisation on href/src of manifest and index.html files.

fix #148
onderceylan added a commit that referenced this issue Mar 8, 2020
@onderceylan
feat(main): added pathOverride option to allow path optimisation on href
7ff2e07 
Added pathOverride option to allow path optimisation on href/src of manifest and index.html files.

fix #148
@onderceylan onderceylan mentioned this issue Mar 8, 2020
Merged
onderceylan pushed a commit that referenced this issue Mar 8, 2020
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
6950543 
# [2.3.0](v2.2.2...v2.3.0) (2020-03-08)

### Features

* **main:** added maskable purpose as default declaration in manifest ([006d73c](006d73c)), closes [#38](#38)
* **main:** added maskable purpose as default declaration in manifest ([84dcc67](84dcc67)), closes [#38](#38)
* **main:** added pathOverride option to allow path optimisation on href ([7ff2e07](7ff2e07)), closes [#148](#148)
* **main:** added pathOverride option to allow path optimisation on href ([2d89cba](2d89cba)), closes [#148](#148)
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
feature request New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added path override and maskable features elegantapp/pwa-asset-generator
2 participants
@pixeline @onderceylan