Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maskable icons for Android #38

Closed
onderceylan opened this issue Sep 2, 2019 · 1 comment
Closed

Add maskable icons for Android #38

onderceylan opened this issue Sep 2, 2019 · 1 comment
Labels
feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@onderceylan
Copy link
Collaborator

onderceylan commented Sep 2, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
As W3C specs on manifest file has been extended with the new purpose field and maskable icons, it's a good idea to add maskable icons feature to pwa-asset-generator.

Describe the solution you'd like
We need to add a new flag --maskable which will be respected when icons are generated. When flag is provided, the manifest file meta has to be aligned with specs here: https://www.w3.org/TR/appmanifest/#icon-masks

A more detailed article on maskable icons is here: https://css-tricks.com/maskable-icons-android-adaptive-icons-for-your-pwa/

Nice to have: if we can detect the safe zone of a custom html input and warn if it exceeds the zone. Intersection Observer API might be handy for that.
@onderceylan onderceylan added the feature request New feature or request label Sep 2, 2019
@onderceylan onderceylan added this to the 1.2.0 milestone Sep 2, 2019
@onderceylan onderceylan added the help wanted Extra attention is needed label Sep 2, 2019
@onderceylan onderceylan modified the milestones: 1.2.0, 1.3.0 Sep 3, 2019
@onderceylan onderceylan modified the milestones: 1.3.0, 1.4.0 Sep 25, 2019
@onderceylan onderceylan removed this from the 1.4.0 milestone Dec 22, 2019
@onderceylan onderceylan added the good first issue Good for newcomers label Feb 9, 2020
onderceylan added a commit that referenced this issue Mar 8, 2020
@onderceylan
feat(main): added maskable purpose as default declaration in manifest
006d73c 
Added 'maskable any' purpose as default purpose declaration in manifest.json file for icons.

fix #38
@onderceylan onderceylan mentioned this issue Mar 8, 2020
Merged
onderceylan pushed a commit that referenced this issue Mar 8, 2020
@semantic-release-bot
chore(release): 2.3.0 [skip ci]
6950543 
# [2.3.0](v2.2.2...v2.3.0) (2020-03-08)

### Features

* **main:** added maskable purpose as default declaration in manifest ([006d73c](006d73c)), closes [#38](#38)
* **main:** added maskable purpose as default declaration in manifest ([84dcc67](84dcc67)), closes [#38](#38)
* **main:** added pathOverride option to allow path optimisation on href ([7ff2e07](7ff2e07)), closes [#148](#148)
* **main:** added pathOverride option to allow path optimisation on href ([2d89cba](2d89cba)), closes [#148](#148)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lnhrdt lnhrdt mentioned this issue Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onderceylan