-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to have self-closing html tags #192
Comments
Hi @zanettin, thank you for using PAG and opening this feature request. What type of project setup do you have? Many of the frameworks, including jsx based template adapters use a single index.html entry. Isn't it the case for you too? |
Thank you very much for your kind reply! I‘am using next.js with a custom _document.tsx file where all meta headers are defined. Since all the requests are handled on server side rendering, no physical index.html file is in the project itself but generated per request on the nodejs instance. the injection of the tags directly into a js/ts file fails but thats ok for me personally. just thought about the above mentioned option to make the copy/past even easier. thanks again for your work on this project and have a nice weekend. |
Thanks for the additional info @zanettin! I will look into this and get back to you soon. It's my pleasure providing this lib to the community, enjoy :) |
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX context. fix #192
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX context. fix #192
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX context. fix #192
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX context. fix #192
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX context. fix #192
# [3.0.0](v2.3.0...v3.0.0) (2020-05-15) ### Bug Fixes * **cli:** fixed conflicting -h option ([3d4f04c](3d4f04c)), closes [#263](#263) ### Features * **main:** added dark mode media query support for html inputs ([c5d2e0d](c5d2e0d)), closes [#227](#227) * **main:** added stricter chrome launch args set ([bdfbef4](bdfbef4)), closes [#229](#229) * **main:** exported appleDeviceSpecsForLaunchImages from module API ([dac56d4](dac56d4)), closes [#248](#248) * **main:** switched to JPG as default output type ([bb5cfec](bb5cfec)), closes [#278](#278) * **meta:** added xhtml option to introduce self-closing meta tags ([0dea81a](0dea81a)), closes [#192](#192) * **node:** drop node 8 support due to its EOL ([030569b](030569b)), closes [#231](#231) ### BREAKING CHANGES * **main:** Due to the large carbon footprint that PNG assets create, switched over using JPG output with compression by default. * **cli:** -h path override usage is dropped. It's replaced with -v shorthand. * **node:** Users with node v8 will not be actively supported.
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Is your feature request related to a problem? Please describe.
it's a feature request. currently the output for html meta tags are non self-closing tags. which works fine for html files but not in the context of JSX.
Describe the solution you'd like
Provide an option to get self-closing html meta tags.
current:
expected:
Describe alternatives you've considered
i could parse it by my self 🤣
Additional context
should be clear otherwise feel free to ask 👍
thank you very much for this great tool! totally love it ❤️
The text was updated successfully, but these errors were encountered: