Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to have self-closing html tags #192

Closed
zanettin opened this issue Mar 19, 2020 · 4 comments · Fixed by #230
Closed

Option to have self-closing html tags #192

zanettin opened this issue Mar 19, 2020 · 4 comments · Fixed by #230
Assignees
Labels
feature request New feature or request released

Comments

@zanettin
Copy link

Is your feature request related to a problem? Please describe.
it's a feature request. currently the output for html meta tags are non self-closing tags. which works fine for html files but not in the context of JSX.

Describe the solution you'd like
Provide an option to get self-closing html meta tags.
current:

<meta name="apple-mobile-web-app-capable" content="yes">
<link rel="icon" type="image/png" sizes="196x196" href="assets/favicon-196.png">

expected:

<meta name="apple-mobile-web-app-capable" content="yes" />
<link rel="icon" type="image/png" sizes="196x196" href="assets/favicon-196.png" />

Describe alternatives you've considered
i could parse it by my self 🤣

Additional context
should be clear otherwise feel free to ask 👍

thank you very much for this great tool! totally love it ❤️

@zanettin zanettin added the feature request New feature or request label Mar 19, 2020
@onderceylan
Copy link
Collaborator

Hi @zanettin, thank you for using PAG and opening this feature request. What type of project setup do you have? Many of the frameworks, including jsx based template adapters use a single index.html entry. Isn't it the case for you too?

@zanettin
Copy link
Author

Thank you very much for your kind reply! I‘am using next.js with a custom _document.tsx file where all meta headers are defined. Since all the requests are handled on server side rendering, no physical index.html file is in the project itself but generated per request on the nodejs instance. the injection of the tags directly into a js/ts file fails but thats ok for me personally. just thought about the above mentioned option to make the copy/past even easier. thanks again for your work on this project and have a nice weekend.

@onderceylan
Copy link
Collaborator

Thanks for the additional info @zanettin! I will look into this and get back to you soon. It's my pleasure providing this lib to the community, enjoy :)

@onderceylan onderceylan self-assigned this Apr 12, 2020
onderceylan added a commit that referenced this issue Apr 13, 2020
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX
context.

fix #192
onderceylan added a commit that referenced this issue Apr 14, 2020
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX
context.

fix #192
onderceylan added a commit that referenced this issue May 13, 2020
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX
context.

fix #192
onderceylan added a commit that referenced this issue May 14, 2020
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX
context.

fix #192
onderceylan added a commit that referenced this issue May 15, 2020
Added xhtml option to introduce self-closing xhtml tags. This will be especially handy in JSX
context.

fix #192
onderceylan pushed a commit that referenced this issue May 15, 2020
# [3.0.0](v2.3.0...v3.0.0) (2020-05-15)

### Bug Fixes

* **cli:** fixed conflicting -h option ([3d4f04c](3d4f04c)), closes [#263](#263)

### Features

* **main:** added dark mode media query support for html inputs ([c5d2e0d](c5d2e0d)), closes [#227](#227)
* **main:** added stricter chrome launch args set ([bdfbef4](bdfbef4)), closes [#229](#229)
* **main:** exported appleDeviceSpecsForLaunchImages from module API ([dac56d4](dac56d4)), closes [#248](#248)
* **main:** switched to JPG as default output type ([bb5cfec](bb5cfec)), closes [#278](#278)
* **meta:** added xhtml option to introduce self-closing meta tags ([0dea81a](0dea81a)), closes [#192](#192)
* **node:** drop node 8 support due to its EOL ([030569b](030569b)), closes [#231](#231)

### BREAKING CHANGES

* **main:** Due to the large carbon footprint that PNG assets create, switched over using JPG
output with compression by default.
* **cli:** -h path override usage is dropped. It's replaced with -v shorthand.
* **node:** Users with node v8 will not be actively supported.
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants