Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-h used for both --path-override and --splash-only #263

Closed
dalmo3 opened this issue May 6, 2020 · 2 comments · Fixed by #230
Closed

-h used for both --path-override and --splash-only #263

dalmo3 opened this issue May 6, 2020 · 2 comments · Fixed by #230
Assignees
Labels
bug Something isn't working released

Comments

@dalmo3
Copy link

dalmo3 commented May 6, 2020

Here I was writing a really long, fully reproducible bug description on how icons were not being generated until I realised I was using -h for overriding path, but it also prevents generating icons.

Of course the workaround is using full flag names, but still needs fixing imo.

@dalmo3 dalmo3 added bug Something isn't working needs verification Bug needs to be verified with reproduction labels May 6, 2020
@onderceylan onderceylan removed the needs verification Bug needs to be verified with reproduction label May 6, 2020
@onderceylan
Copy link
Collaborator

Hi @dalmo3, thanks for your feedback! It indeed is a bug. I will look at it asap.

@onderceylan onderceylan self-assigned this May 7, 2020
onderceylan added a commit that referenced this issue May 7, 2020
-h option was used for both --path-override --splash-only flags.

BREAKING CHANGE: -h path override usage is dropped. It's replaced with -v shorthand.

fix #263
onderceylan added a commit that referenced this issue May 13, 2020
-h option was used for both --path-override --splash-only flags.

BREAKING CHANGE: -h path override usage is dropped. It's replaced with -v shorthand.

fix #263
onderceylan added a commit that referenced this issue May 14, 2020
-h option was used for both --path-override --splash-only flags.

BREAKING CHANGE: -h path override usage is dropped. It's replaced with -v shorthand.

fix #263
onderceylan added a commit that referenced this issue May 15, 2020
-h option was used for both --path-override --splash-only flags.

BREAKING CHANGE: -h path override usage is dropped. It's replaced with -v shorthand.

fix #263
onderceylan pushed a commit that referenced this issue May 15, 2020
# [3.0.0](v2.3.0...v3.0.0) (2020-05-15)

### Bug Fixes

* **cli:** fixed conflicting -h option ([3d4f04c](3d4f04c)), closes [#263](#263)

### Features

* **main:** added dark mode media query support for html inputs ([c5d2e0d](c5d2e0d)), closes [#227](#227)
* **main:** added stricter chrome launch args set ([bdfbef4](bdfbef4)), closes [#229](#229)
* **main:** exported appleDeviceSpecsForLaunchImages from module API ([dac56d4](dac56d4)), closes [#248](#248)
* **main:** switched to JPG as default output type ([bb5cfec](bb5cfec)), closes [#278](#278)
* **meta:** added xhtml option to introduce self-closing meta tags ([0dea81a](0dea81a)), closes [#192](#192)
* **node:** drop node 8 support due to its EOL ([030569b](030569b)), closes [#231](#231)

### BREAKING CHANGES

* **main:** Due to the large carbon footprint that PNG assets create, switched over using JPG
output with compression by default.
* **cli:** -h path override usage is dropped. It's replaced with -v shorthand.
* **node:** Users with node v8 will not be actively supported.
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants