Don't throw error when value is empty in value editor

- AUT-2588
emartech · Jan 30, 2024 · 65659f6 · 65659f6
1 parent 7030348
commit 65659f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/renderer/components/secret-editor/value-editor/value-editor.spec.js b/src/renderer/components/secret-editor/value-editor/value-editor.spec.js
@@ -14,6 +14,11 @@ describe('ValueEditor', () => {
       const { vm } = mountWithStore(ValueEditor, { propsData: { value: 'something' } });
       expect(vm.editorLanguage).to.eql('text');
     });
+
+    it('should return text when value is null', () => {
+      const { vm } = mountWithStore(ValueEditor, { propsData: { value: null } });
+      expect(vm.editorLanguage).to.eql('text');
+    });
   });
 
   describe('#editorTheme', () => {

diff --git a/src/renderer/lib/json-helper/json-helper.js b/src/renderer/lib/json-helper/json-helper.js
@@ -1,4 +1,5 @@
 import { neatJSON } from 'neatjson';
+import { isEmpty } from 'lodash';
 
 export const isValidJson = (data) => {
   if (!looksLikeJson(data)) return false;
@@ -15,6 +16,9 @@ export const isJsonWithErrors = (value) => {
 };
 
 export const looksLikeJson = (value) => {
+  if (isEmpty(value)) {
+    return false;
+  }
   const valueWithoutSpaces = value.toString().replace(/\s/g, '');
   return (
     (valueWithoutSpaces.startsWith('{') && valueWithoutSpaces.endsWith('}')) ||