Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HostType variable in mod_mam_rdbms_prefs/user #3157

Merged
merged 7 commits into from
Jun 17, 2021

Conversation

arcusfelis
Copy link
Contributor

This PR addresses MIM-1412 (kinda)

Proposed changes include:

  • prefs/user and utils modules use HostType variable and host_type type where needed.
  • no functional changes.
  • ah, and I've refactored hooks there.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #3157 (5ff96d7) into master (0d82dc9) will decrease coverage by 0.05%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
- Coverage   79.89%   79.84%   -0.06%     
==========================================
  Files         396      396              
  Lines       32335    32274      -61     
==========================================
- Hits        25834    25768      -66     
- Misses       6501     6506       +5     
Impacted Files Coverage Δ
src/gen_mod.erl 73.61% <ø> (ø)
src/mam/mod_mam.erl 88.88% <ø> (ø)
src/mam/mod_mam_rdbms_user.erl 80.55% <77.77%> (+7.97%) ⬆️
src/mam/mod_mam_cache_user.erl 87.71% <100.00%> (-2.70%) ⬇️
src/mam/mod_mam_rdbms_prefs.erl 97.01% <100.00%> (-0.66%) ⬇️
src/mam/mod_mam_utils.erl 89.89% <100.00%> (ø)
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_rdbms_async_pool_writer.erl 62.96% <0.00%> (-4.63%) ⬇️
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 73.58% <0.00%> (-3.78%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d82dc9...5ff96d7. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have one minor style-related remark. Fixing is optional.

src/mam/mod_mam_cache_user.erl Outdated Show resolved Hide resolved
@chrzaszcz chrzaszcz merged commit 78880e6 into master Jun 17, 2021
@chrzaszcz chrzaszcz deleted the mu-mam-rdbms-uses-dyn-dom branch June 17, 2021 17:20
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants