-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CETS backend for mongoose_cluster_id (minimal logic) #4136
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4136 +/- ##
==========================================
+ Coverage 84.06% 84.07% +0.01%
==========================================
Files 558 559 +1
Lines 34016 34035 +19
==========================================
+ Hits 28595 28616 +21
+ Misses 5421 5419 -2
☔ View full report in Codecov by Sentry. |
359703b
to
16e8d99
Compare
16e8d99
to
7e3de03
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7e3de03
to
3affe01
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ffc78a8 small_tests_24 / small_tests / ffc78a8 small_tests_25 / small_tests / ffc78a8 small_tests_25_arm64 / small_tests / ffc78a8 ldap_mnesia_24 / ldap_mnesia / ffc78a8 dynamic_domains_mysql_redis_25 / mysql_redis / ffc78a8 ldap_mnesia_25 / ldap_mnesia / ffc78a8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ffc78a8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ffc78a8 pgsql_cets_25 / pgsql_cets / ffc78a8 internal_mnesia_25 / internal_mnesia / ffc78a8 mysql_redis_25 / mysql_redis / ffc78a8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ffc78a8 pgsql_mnesia_24 / pgsql_mnesia / ffc78a8 pgsql_mnesia_25 / pgsql_mnesia / ffc78a8 mssql_mnesia_25 / odbc_mssql_mnesia / ffc78a8 muc_SUITE:register:user_changes_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"00f3c54b89751252fc631d7268d6c9ac">>},
{<<"to">>,<<"muc.localhost">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-1f225b4026">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"muc.localhost">>},
{<<"to">>,<<"alice_user_changes_nick_2645@localhost/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"00f3c54b89751252fc631d7268d6c9ac">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"... mssql_mnesia_25 / odbc_mssql_mnesia / ffc78a8 graphql_server_SUITE:admin_cli:clustering_tests:join_successful{error,{#{expected_type => ok,
response_code => {exit_status,1},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,join_successful,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,150}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / ffc78a8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok in general, I added some comments.
Fix errors in distributed_helper
…e_from_cluster_http
ffc78a8
to
48f1203
Compare
small_tests_25_arm64 / small_tests / 48f1203 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 48f1203 small_tests_24 / small_tests / 48f1203 small_tests_25 / small_tests / 48f1203 ldap_mnesia_24 / ldap_mnesia / 48f1203 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 48f1203 dynamic_domains_mysql_redis_25 / mysql_redis / 48f1203 ldap_mnesia_25 / ldap_mnesia / 48f1203 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 48f1203 pgsql_mnesia_24 / pgsql_mnesia / 48f1203 internal_mnesia_25 / internal_mnesia / 48f1203 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 48f1203 pgsql_cets_25 / pgsql_cets / 48f1203 mssql_mnesia_25 / odbc_mssql_mnesia / 48f1203 mysql_redis_25 / mysql_redis / 48f1203 pgsql_mnesia_25 / pgsql_mnesia / 48f1203 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
This PR addresses "MIM-2040 System metrics fail with no_client_id".
This is a copy of #4135 but the difference is that this branch does not try to fix all the tests, that still assume Mnesia is started.
Proposed changes include:
Added cets:insert_serial/2
. See PR for CETS library: Add cets:insert_serial/2 cets#33