Add cets:insert_serial/2 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 9 9
Lines 612 613 +1
=======================================
+ Hits 596 597 +1
Misses 16 16
☔ View full report in Codecov by Sentry. |
This was referenced Oct 3, 2023
|
@chrzaszcz Propose better name for insert_serial, if you want. insert_serialized? upsert_though_the_main_node? :) |
chrzaszcz
reviewed
Oct 6, 2023
It is a reverted change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All `insert_serial' calls are sent to the leader node first.
Similar to
insert_new/2, but overwrites the data silently on conflict.It could be used to update entries, which use not node-specific keys.
This function ensures that all nodes would agree on the value, if they try to insert (OR overwrite) a record with the same key at once.
It is used by esl/MongooseIM#4136