-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename c2s_state_timeout
option to state_timeout
#4363
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4363 +/- ##
==========================================
- Coverage 84.83% 84.80% -0.03%
==========================================
Files 553 553
Lines 33773 33773
==========================================
- Hits 28650 28640 -10
- Misses 5123 5133 +10 ☔ View full report in Codecov by Sentry. |
d272390
to
552597b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Now, `c2s` is not doubled in the name, so `listen.c2s.c2s_state_timeout` has become `listen.c2s.state_timeout`. Note that for websockets, I decided to keep the prefix, so its `listen.http.handlers.mod_websockets.c2s_state_timeout`.
552597b
to
2337813
Compare
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 2337813 small_tests_26 / small_tests / 2337813 small_tests_27 / small_tests / 2337813 small_tests_27_arm64 / small_tests / 2337813 ldap_mnesia_27 / ldap_mnesia / 2337813 dynamic_domains_mysql_redis_27 / mysql_redis / 2337813 ldap_mnesia_26 / ldap_mnesia / 2337813 internal_mnesia_27 / internal_mnesia / 2337813 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 2337813 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2337813 pgsql_cets_27 / pgsql_cets / 2337813 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 2337813 pgsql_mnesia_26 / pgsql_mnesia / 2337813 pgsql_mnesia_27 / pgsql_mnesia / 2337813 mysql_redis_27 / mysql_redis / 2337813 mssql_mnesia_27 / odbc_mssql_mnesia / 2337813 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Now,
c2s
is not doubled in the name, solisten.c2s.c2s_state_timeout
has becomelisten.c2s.state_timeout
. Note that for websockets, I decided to keep the prefix, so itslisten.http.handlers.mod_websockets.c2s_state_timeout
.