Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename c2s_state_timeout option to state_timeout #4363

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gustawlippa
Copy link
Contributor

Now, c2s is not doubled in the name, so listen.c2s.c2s_state_timeout has become listen.c2s.state_timeout. Note that for websockets, I decided to keep the prefix, so its listen.http.handlers.mod_websockets.c2s_state_timeout.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (344108f) to head (2337813).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
- Coverage   84.83%   84.80%   -0.03%     
==========================================
  Files         553      553              
  Lines       33773    33773              
==========================================
- Hits        28650    28640      -10     
- Misses       5123     5133      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gustawlippa gustawlippa force-pushed the rename_c2s_state_timeout branch from d272390 to 552597b Compare August 22, 2024 13:18
@mongoose-im

This comment was marked as outdated.

Now, `c2s` is not doubled in the name, so `listen.c2s.c2s_state_timeout` has
become `listen.c2s.state_timeout`. Note that for websockets, I decided to keep
the prefix, so its `listen.http.handlers.mod_websockets.c2s_state_timeout`.
@gustawlippa gustawlippa force-pushed the rename_c2s_state_timeout branch from 552597b to 2337813 Compare August 22, 2024 14:16
@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 22, 2024

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 2337813
Reports root/ big
OK: 439 / Failed: 0 / User-skipped: 47 / Auto-skipped: 0


small_tests_26 / small_tests / 2337813
Reports root / small


small_tests_27 / small_tests / 2337813
Reports root / small


small_tests_27_arm64 / small_tests / 2337813
Reports root / small


ldap_mnesia_27 / ldap_mnesia / 2337813
Reports root/ big
OK: 2338 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / 2337813
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 145 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 2337813
Reports root/ big
OK: 2338 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / 2337813
Reports root/ big
OK: 2478 / Failed: 0 / User-skipped: 765 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 2337813
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 2337813
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / 2337813
Reports root/ big
OK: 4532 / Failed: 0 / User-skipped: 179 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 2337813
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 2337813
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_mnesia_27 / pgsql_mnesia / 2337813
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / 2337813
Reports root/ big
OK: 4991 / Failed: 0 / User-skipped: 140 / Auto-skipped: 0


mssql_mnesia_27 / odbc_mssql_mnesia / 2337813
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

@gustawlippa gustawlippa marked this pull request as ready for review August 22, 2024 14:44
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JanuszJakubiec JanuszJakubiec merged commit ed4ec1d into master Aug 28, 2024
4 checks passed
@JanuszJakubiec JanuszJakubiec deleted the rename_c2s_state_timeout branch August 28, 2024 08:27
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants