connect to new nodes / disconnect from unused nodes #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirstycrow
force-pushed
the
feature-dynamic-cluster-nodes
branch
from
d94f468
to
cfeab77
Compare
thirstycrow
force-pushed
the
feature-dynamic-cluster-nodes
branch
from
cfeab77
to
4309ccd
Compare
thirstycrow
commented
Feb 19, 2017
| redisServerConnections.keys.foreach { server => | ||
| if (!serverSet.contains(server)) { | ||
| redisServerConnections.remove(server) | ||
| .map(connection => _system.scheduler.scheduleOnce(1.second)(_system.stop(connection.actor))) |
There was a problem hiding this comment.
Is it the correct way to disconnect from a cluster node? I tried to do it without scheduling, but failed the clusterNodes test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When slots is updated, RedisCluster should connect to new nodes, and disconnect from the nodes that's not serving data any longer.