Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1014: Use keccak256 name instead of sha3 #1247

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Jul 23, 2018

Do not refer to the hash function as sha3 because it is SHA3. Use more precise keccak256 name.

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1014 requires approval from one of (@vbuterin)

@chfast
Copy link
Member Author

chfast commented Aug 25, 2018

@djrtwo you promised me your intervention here.

@djrtwo
Copy link
Contributor

djrtwo commented Aug 25, 2018

Gave a nudge to @vbuterin for a merge in another channel. Trying again here.

Hey @vbuterin, please merge this tiny modification to your PR. It changes sha to keccak256 for clarity.

@djrtwo
Copy link
Contributor

djrtwo commented Aug 31, 2018

Got the go ahead from Vitalik to merge. @chfast @Arachnid
screen shot 2018-08-31 at 11 35 26 am

Do not refer to the hash function as `sha3` because it is SHA3. Use more precise `keccak256` name.
@chfast chfast force-pushed the eip-1014-keccak256 branch from 54a8367 to 5d9f96a Compare August 31, 2018 16:47
@MicahZoltu
Copy link
Contributor

If @vbuterin isn't going to maintain this PR in GitHub, or at least drop a note in this PR then I recommend just creating a new PR where you are the primary author and we can get that merged. I dislike the idea of using Telegram/Whatsapp screenshots as a means of PR merge approvals.

EIPs are all CC-0 licensed, so you can freely just copy/paste the EIP with a new number and your name as the author without violating any silly copyright rules.

@axic
Copy link
Member

axic commented Sep 19, 2018

EIPs are all CC-0 licensed

Well, except this one :)

@chfast
Copy link
Member Author

chfast commented Sep 19, 2018

EIPs are all CC-0 licensed

Well, except this one :)

And this one: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1355.md.

@holiman holiman merged commit 822bc28 into ethereum:master Sep 25, 2018
@holiman
Copy link
Contributor

holiman commented Sep 25, 2018

yolo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants