-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-1014: Use keccak256 name instead of sha3 #1247
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
@djrtwo you promised me your intervention here. |
Do not refer to the hash function as `sha3` because it is SHA3. Use more precise `keccak256` name.
54a8367
to
5d9f96a
Compare
If @vbuterin isn't going to maintain this PR in GitHub, or at least drop a note in this PR then I recommend just creating a new PR where you are the primary author and we can get that merged. I dislike the idea of using Telegram/Whatsapp screenshots as a means of PR merge approvals. EIPs are all CC-0 licensed, so you can freely just copy/paste the EIP with a new number and your name as the author without violating any silly copyright rules. |
Well, except this one :) |
And this one: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1355.md. |
yolo |
Do not refer to the hash function as
sha3
because it is SHA3. Use more precisekeccak256
name.