Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid overflow in slashing penalty calculation #1286

Merged
merged 5 commits into from
Jul 11, 2019
Merged

avoid overflow in slashing penalty calculation #1286

merged 5 commits into from
Jul 11, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jul 10, 2019 •
edited
Loading

Addresses #1284

Perform penalty calculation on the EFFECTIVE_BALANCE_INCREMENT fraction of GWEI to avoid 64-bit overflows

@djrtwo djrtwo requested a review from JustinDrake July 10, 2019 21:30
@djrtwo djrtwo changed the title avoid overflow in slashing penalty calculation [WIP] avoid overflow in slashing penalty calculation Jul 10, 2019
@djrtwo djrtwo changed the title [WIP] avoid overflow in slashing penalty calculation avoid overflow in slashing penalty calculation Jul 10, 2019
@JustinDrake JustinDrake added the general:presentation Presentation (as opposed to content) label Jul 11, 2019
@JustinDrake JustinDrake merged commit 6dc3067 into v08x Jul 11, 2019
@JustinDrake JustinDrake mentioned this pull request Jul 11, 2019
Closed
@djrtwo djrtwo deleted the avoid-overflow branch July 11, 2019 13:34
@terencechain terencechain mentioned this pull request Jul 15, 2019
Closed
11 tasks
@shayzluf shayzluf mentioned this pull request Jul 16, 2019
Merged
@benjaminion benjaminion mentioned this pull request Aug 10, 2020
Merged
1 task
@pietjepuk2 pietjepuk2 mentioned this pull request Dec 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @JustinDrake