Add initial version of kzg_7594 test generator #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jtraglia
changed the title
hwwhww
approved these changes
Apr 23, 2024
tests/generators/kzg_7594/main.py
Outdated
Comment on lines
17
to
19
| ############################################################################### | ||
| # Helper functions | ||
| ############################################################################### |
There was a problem hiding this comment.
probably good to move the 4844 duplicate helpers / constants to a tests/core/pyspec/eth2spec/test/utils/kzg_tests.py and import everything from it.
asn-d6
reviewed
Apr 24, 2024
|
Thanks @asn-d6 😄 I can confirm that c-kzg-4844:das passes all of these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
kzg_7594generator and an initial set of tests. The structure and a lot of the variables are copied from thekzg_4844generator. We can add more tests later, after this is merged.Depends on #3684, it must be merged prior to this.
Edit: I can confirm that c-kzg passes these reference tests. Added in this commit.