Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename formats/kzg to formats/kzg_4844 #3716

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Rename formats/kzg to formats/kzg_4844 #3716

merged 1 commit into from
Apr 23, 2024

Conversation

jtraglia
Copy link
Member

We should rename this so that it matches the generators directory:

ralexstokes
ralexstokes approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good,

are you envisioning a kzg_7495 generator that is substantially different enough to justify a different format?

@jtraglia
Copy link
Member Author

jtraglia commented Apr 23, 2024 •
edited
Loading

Yes, I'm working on that generator right now. I think it would be best break it out into its own formats directory.

@hwwhww hwwhww added EIP-7594 PeerDAS scope:CI/tests/pyspec and removed EIP-7594 PeerDAS labels Apr 23, 2024
@jtraglia jtraglia merged commit 731caf8 into ethereum:dev Apr 23, 2024
28 checks passed
@jtraglia jtraglia deleted the rename-kzg-formats branch April 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @ralexstokes @hwwhww