Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs,tests): add links to the online test case docs in the EOF tracker #838

Merged
merged 12 commits into from
Sep 25, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Sep 25, 2024

🗒️ Description

Adds links from the test module and test function specs listed in the EOF tracker to the relevant pages in the online doc. The test function pages are relatively new, cf #801.

Demo available here:
https://ethereum.github.io/execution-spec-tests/pr-838-preview/tests/prague/eip7692_eof_v1/tracker/

🔗 Related Issues

#801

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added scope:tests Scope: Test cases scope:docs Scope: Documentation type:feat type: Feature labels Sep 25, 2024
@danceratopz danceratopz marked this pull request as ready for review September 25, 2024 13:42
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit f41fb29 into main Sep 25, 2024
7 checks passed
@marioevz marioevz deleted the docs/add-links-to-eof-tracker branch September 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:docs Scope: Documentation scope:tests Scope: Test cases type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants