doc says functions are by default internal - parity exploit

[SCBuergel]

I was just made aware that the docs currently say:

By default, function types are internal, so the internal keyword can be omitted.

To the best of my knowledge that is not true, otherwise the Parity multisig exploit would not have happened. This is important to get right. Or do you plan to change that and updated the docs already ahead of time?

[5chdn]

Thanks, just raised that here: #2608 (comment)

But might be worth a separate ticket.

[axic]

The documentation should be clearer, but function types refer to function type variables:

function f() {
  // This creates a function type (and it defaults to internal visibility):
  function (uint, uint) x;

  // It is possible to retrieve the type of a function (the function above defaults to public visibility):
  var y = f;

  // Assign the function f() to a local function type:
  function () external z = this.f;
}

The part of the documentation referring to functions says:

Functions can be specified as being external, public, internal or private, where the default is public.

[SCBuergel]

Agree, this should be a lot clearer. Many people read the doc not like a book and pick up all definitions that you gave earlier. Lets make it clear again in the section on function types. I would call that entire section "Function parameter types" to avoid any confusion in the first place. But at least rephrase:

By default, function types are internal, so the internal keyword can be omitted

To something like

By default, function variable types are internal, so the internal keyword can be omitted. Note that function visibility is not external/public/internal/private and you need to set these yourself if needed.