Clarify visibility of function types vs. contract functions #2623
Conversation
| @@ -337,7 +337,8 @@ function type should not return anything, the whole ``returns (<return types>)`` | |||
| part has to be omitted. | |||
|
|
|||
| By default, function types are internal, so the ``internal`` keyword can be | |||
| omitted. | |||
| omitted. Note that this is not the case for functions defined on a contract, | |||
There was a problem hiding this comment.
I do not think this is the right way to explain. If you look up a few lines, that lists what is valid for a function type. This would weirdly suggest public is also valid a function type.
Having read the entire section again I think the intro should be clarified, otherwise this feels like only a workaround.
Conversion of functions to function types and the subtleties (with conversion examples) may help clear up the confusion.
There was a problem hiding this comment.
Hmmm... I see what you mean. Confusion seems to root from the overlap between internal/external function types, and public/private/internal/external contract functions. I agree that explaining the differences first, and providing some examples of conversions between the two, would make this clarification later on a lot clearer. As-is it can cause more confusion, which is obviously not what I intended to do here.
There was a problem hiding this comment.
So I've reread this part of the documentation again, and I agree this isn't the right way to explain this at all. I'm going to close this PR.
Closed #2617