Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue warning when using deprecated SELFDESTRUCT #13884

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Issue warning when using deprecated SELFDESTRUCT #13884

merged 2 commits into from
Jan 26, 2023

Conversation

nikola-matic
Copy link
Collaborator

@nikola-matic nikola-matic commented Jan 19, 2023 •
edited
Loading

Fixes #13844.

@nikola-matic nikola-matic self-assigned this Jan 19, 2023
@nikola-matic nikola-matic added this to the 0.8.18 milestone Jan 19, 2023
@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch from 663d66d to 95bb41b Compare January 19, 2023 08:36
@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch 2 times, most recently from 7e42710 to 698353a Compare January 20, 2023 13:37
@nikola-matic nikola-matic marked this pull request as ready for review January 20, 2023 13:37
@nikola-matic nikola-matic marked this pull request as draft January 23, 2023 10:33
@ekpyron
Copy link
Member

ekpyron commented Jan 23, 2023

I mean, ideally we'd change the docs examples as well, s.t. they don't use it :-). But we can make that a separate issue. Apart from that only the inline assembly warning, as discussed.

@nikola-matic
Copy link
Collaborator Author

I mean, ideally we'd change the docs examples as well, s.t. they don't use it :-). But we can make that a separate issue. Apart from that only the inline assembly warning, as discussed.

Do we have a place in the docs where we track deprecated and removed instructions/features and their proposed alternatives, a la boost?

@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch from 698353a to 4b4b94c Compare January 24, 2023 10:33
@nikola-matic nikola-matic marked this pull request as ready for review January 24, 2023 10:34
@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch from e37d292 to 6f5e12c Compare January 25, 2023 07:29
@nikola-matic nikola-matic requested a review from axic January 25, 2023 07:30
@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch from 6f5e12c to 5b643f4 Compare January 25, 2023 15:55
ekpyron
ekpyron reviewed Jan 25, 2023
View reviewed changes
libyul/AsmAnalysis.cpp Outdated Show resolved Hide resolved
cameel
cameel reviewed Jan 25, 2023
View reviewed changes
docs/units-and-global-variables.rst Outdated Show resolved Hide resolved
docs/units-and-global-variables.rst Show resolved Hide resolved
test/libyul/yulSyntaxTests/selfdestruct.yul Show resolved Hide resolved
@Stasian007 Stasian007 mentioned this pull request Jan 25, 2023
Open
@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch from 5b643f4 to 7e6905b Compare January 26, 2023 08:21
@nikola-matic nikola-matic mentioned this pull request Jan 26, 2023
Closed
cameel
cameel previously approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

docs/yul.rst Outdated Show resolved Hide resolved
@nikola-matic nikola-matic force-pushed the deprecation-warning-for-selfdestruct branch from 7e6905b to 83a9374 Compare January 26, 2023 12:42
@nikola-matic nikola-matic merged commit 019d13d into develop Jan 26, 2023
@nikola-matic nikola-matic deleted the deprecation-warning-for-selfdestruct branch January 26, 2023 13:33
@MathisGD MathisGD mentioned this pull request Apr 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekpyron ekpyron ekpyron left review comments

@cameel cameel cameel approved these changes

@axic axic Awaiting requested review from axic

Assignees

@nikola-matic nikola-matic

Labels
None yet
Projects
Solidity Focus Board
Archived in project
Milestone
0.8.18
Development

Successfully merging this pull request may close these issues.

Deprecation warning for SELFDESTRUCT
4 participants
@nikola-matic @ekpyron @axic @cameel