fix(build): Update dependencies and build pipeline #51
Conversation
|
Why'd everything get double quotes? |
|
Not sure that is odd, we have prettier setup by default. Looks like prettier related, I updated them and then on commit it reverted. I added a prettier config, to avoid it updating things just to get eslint to change them back. |
| @@ -109,6 +110,9 @@ const _genDist = ({minify = false} = {}) => | |||
| // convert JSON files to ES6 modules, so they can be included in Rollup bundle | |||
| rollupJson(), | |||
|
|
|||
| // gives rollup ability to read typescript files | |||
| rollupTypescript(), | |||
There was a problem hiding this comment.
Interesting! How was this working before????
There was a problem hiding this comment.
I am not really sure about that. It was in out package.json so maybe it was implied.
| ]); | ||
| gulp.task( | ||
| 'build:lib', | ||
| gulp.series( |
There was a problem hiding this comment.
Oh looks like gulp@4 introduced gulp.series? I'm guessing because there's also a parallel version...
There was a problem hiding this comment.
Yes I assumed we wanted to use series, but I am open to using parallel.
| @@ -4,4 +4,5 @@ module.exports = Object.assign({}, baseConfig, { | |||
| runner: 'jest-runner-eslint', | |||
| displayName: 'lint', | |||
| testMatch: ['<rootDir>/src/**/*.(ts|js)'], | |||
| watchPlugins: ['jest-runner-eslint/watch-fix'], | |||
There was a problem hiding this comment.
Yeah! It was painful not having that. Very nice to have it as a watch option.
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Updated all dependencies to fix error in build pipeline.
fixes #43
How Has This Been Tested?
Locally, I have used node v10 to build the project. Travis will also run all check against all supported versions.
I plan to also check against node v 11 and re-enable it in the build jobs.
Screenshots (if appropriate):
Checklist:
yarn validateto ensure that tests, typescript and linting are all in order.