dev: update dev packages #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmvp
reviewed
Oct 25, 2018
| @@ -25,7 +25,7 @@ describe('request', () => { | |||
| restoreMockFetch(); | |||
| }); | |||
|
|
|||
| it('makes request to API base url default w/ no token when no configuration is specified', async () => { | |||
| it('makes request to API base url default w/ no token when no configuration is specified', async() => { | |||
There was a problem hiding this comment.
the eslint rule wants to get rid of the space? ugh
There was a problem hiding this comment.
I think @jonathancreamer-eb called me out on this in brite-cli as the no space is expected.
|
DevDeps were updated in #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to jest and eslint packages mainly a few other tools.
Note: this does not resolve the node@11 issue, just some low hanging fruit.
How Has This Been Tested?
Screenshots (if appropriate):
Checklist:
yarn validateto ensure that tests, typescript and linting are all in order.