Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: update dev packages #42

Closed
wants to merge 1 commit into from
Closed

dev: update dev packages #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@
"@babel/preset-env": "^7.0.0-beta.40",
"@babel/preset-typescript": "^7.0.0-beta.40",
"@types/isomorphic-fetch": "^0.0.34",
"@types/jest": "^22.1.3",
"@types/node": "^9.4.6",
"babel-eslint": "^7.0.0",
"@types/jest": "^23.3.7",
"@types/node": "^10.12.0",
"babel-eslint": "^10.0.1",
"bundlesize": "^0.17.0",
"eslint": "^3.0.0",
"eslint": "^5.7.0",
"eslint-config-eventbrite": "^4.1.0",
"eslint-plugin-import": "^2.0.0",
"eslint-plugin-typescript": "^0.9.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-typescript": "^0.12.0",
"gulp": "^3.9.1",
"gulp-babel": "^7.0.1",
"gulp-debug": "^4.0.0",
Expand All @@ -81,12 +81,12 @@
"gulp-sourcemaps": "^2.6.4",
"gulp-uglify": "^3.0.0",
"husky": "^0.14.3",
"jest": "^22.4.0",
"jest-runner-eslint": "^0.4.0",
"jest-runner-tsc": "^1.2.0",
"lint-staged": "^6.1.0",
"jest": "^23.6.0",
"jest-runner-eslint": "^0.7.1",
"jest-runner-tsc": "^1.3.2",
"lint-staged": "^7.3.0",
"node": "^8.9.2",
"npm-run-all": "^4.1.2",
"npm-run-all": "^4.1.3",
"prettier-eslint-cli": "^4.7.1",
"rollup": "^0.56.3",
"rollup-plugin-babel": "^4.0.0-beta.2",
Expand Down
6 changes: 3 additions & 3 deletions src/__tests__/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe('request', () => {
restoreMockFetch();
});

it('makes request to API base url default w/ no token when no configuration is specified', async () => {
it('makes request to API base url default w/ no token when no configuration is specified', async() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the eslint rule wants to get rid of the space? ugh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jonathancreamer-eb called me out on this in brite-cli as the no space is expected.

const {request} = eventbrite();

await expect(request('/users/me/')).resolves.toEqual(
Expand All @@ -39,7 +39,7 @@ describe('request', () => {
);
});

it('makes request to API base url override w/ specified token', async () => {
it('makes request to API base url override w/ specified token', async() => {
const {request} = eventbrite({
token: MOCK_TOKEN,
baseUrl: MOCK_BASE_URL,
Expand All @@ -60,7 +60,7 @@ describe('request', () => {
);
});

it('properly specifies authorization header token when other header options are already specified', async () => {
it('properly specifies authorization header token when other header options are already specified', async() => {
const {request} = eventbrite({
token: MOCK_TOKEN,
});
Expand Down
18 changes: 9 additions & 9 deletions src/__tests__/request.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('request', () => {
mockFetch(getSuccessfulCodeRes());
});

it('calls fetch and calls fetch with appropriate defaults', async () => {
it('calls fetch and calls fetch with appropriate defaults', async() => {
await request(TEST_URL);

expect(getMockFetch()).toHaveBeenCalledTimes(1);
Expand All @@ -41,7 +41,7 @@ describe('request', () => {
);
});

it('calls fetch and adds "application/json" content type when method is not GET', async () => {
it('calls fetch and adds "application/json" content type when method is not GET', async() => {
await request(TEST_URL, {method: 'POST', body: '{}'});

expect(getMockFetch()).toHaveBeenCalledTimes(1);
Expand All @@ -58,7 +58,7 @@ describe('request', () => {
);
});

it('calls fetch and respects overrides in options', async () => {
it('calls fetch and respects overrides in options', async() => {
await request(TEST_URL, {credentials: 'omit'});

expect(getMockFetch()).toHaveBeenCalledTimes(1);
Expand All @@ -70,7 +70,7 @@ describe('request', () => {
);
});

it('calls fetch and respects overrides in option headers', async () => {
it('calls fetch and respects overrides in option headers', async() => {
await request(TEST_URL, {
headers: {
'X-TEST': 'testHeader',
Expand All @@ -92,7 +92,7 @@ describe('request', () => {
);
});

it('calls fetch and merges overrides with defaults in option headers', async () => {
it('calls fetch and merges overrides with defaults in option headers', async() => {
await request(TEST_URL, {
headers: {
'X-TEST': 'testHeader',
Expand All @@ -116,7 +116,7 @@ describe('request', () => {
})
);
});
it('calls fetch and return parsed response JSON data', async () => {
it('calls fetch and return parsed response JSON data', async() => {
await expect(request(TEST_URL)).resolves.toEqual(
MOCK_USERS_ME_RESPONSE_DATA
);
Expand All @@ -126,7 +126,7 @@ describe('request', () => {
});

describe('error handling', () => {
it('should reject only with response when response is invalid JSON', async () => {
it('should reject only with response when response is invalid JSON', async() => {
const response = new Response('{sa;dfsdfi');

mockFetch(response);
Expand All @@ -136,7 +136,7 @@ describe('request', () => {
});
});

it('calls fetch and rejects with parsed error when there is a status error', async () => {
it('calls fetch and rejects with parsed error when there is a status error', async() => {
const response = getInternalErrorRes();

mockFetch(response);
Expand All @@ -153,7 +153,7 @@ describe('request', () => {
expect(getMockFetch()).toHaveBeenCalledTimes(1);
});

it('calls fetch and rejects with parsed argument errors when there is an ARGUMENT_ERROR', async () => {
it('calls fetch and rejects with parsed argument errors when there is an ARGUMENT_ERROR', async() => {
const response = getArgumentsErrorRes();

mockFetch(response);
Expand Down
Loading