Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant dependencies from file notebook_requirements.txt #308

Closed
ckunki opened this issue Jul 19, 2024 · 0 comments · Fixed by #319
Closed

Remove redundant dependencies from file notebook_requirements.txt #308

ckunki opened this issue Jul 19, 2024 · 0 comments · Fixed by #319
Assignees
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Jul 19, 2024

File notebook_requirements.txt contains dependencies for using the Jupyter notebooks.

Most dependencies of Jupyter notebooks are already defined by notebook-connector which is installed from pypi.

Duplicate entries in the file named above are redundant and also error-prone, as inconsistent constellations make pi install fail.

The current ticket therefore requests to remove the redundant entries from file notebook_requirements.txt.

@ckunki ckunki added the refactoring Code improvement without behavior change label Jul 19, 2024
@ckunki ckunki self-assigned this Aug 21, 2024
tkilias added a commit that referenced this issue Aug 25, 2024
…tests, move ibis notebook to new download URL, (#319)

* #308: Updated Dependencies of Jupyter Environment and pyproject.toml
* #298: Fixed vulnerabilities 
* #322: Made URL in IBIS notebook point to a new example data bucket
* #318: Re-enabled tests for cloud storage notebook

* Updated version constraint for stopwatch
* Replaced GitHub dependency in file test_dependencies.txt for notebook tests by PyPI dependency.
* Fixed CloudFormation lint tests
* Fixed name of docker registry in integration test to satisfy legal names for docker registries.
* Updated changes file
* Changed version to 3.0.0
* Fixed cloud storage notebook test
* Fixed cloud_store_config.ipynb temporarily by correctly reimplement bfs_utils.put_file


---------

Co-authored-by: Torsten Kilias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
1 participant