Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate Connector with JDBC driver #22

Closed
redcatbear opened this issue Sep 2, 2021 · 2 comments · Fixed by #23
Closed

Evaluate Connector with JDBC driver #22

redcatbear opened this issue Sep 2, 2021 · 2 comments · Fixed by #23
Assignees
@kaklakariada
Labels
refactoring Code improvement without behavior change

Comments

@redcatbear
Copy link
Contributor

Situation

Currently the Tableau connector is based on the ODBC driver. Tableau suggests switching to the JDBC driver.
Since the JDBC driver can be bundled with the connector, this makes installation more convenient for users.

Acceptance Criteria

  1. Connector based on JDBC driver exists
  2. TDVT tests are green
  3. Integration tests are green
  4. Total query runtime execution time (including driver overhead) comparison between the two variants exists
@redcatbear redcatbear added refactoring Code improvement without behavior change source:external labels Sep 2, 2021
@kaklakariada kaklakariada mentioned this issue Oct 1, 2021
Merged
@kaklakariada
Copy link
Collaborator

Exasol does not support the SPLIT() function, we need to skip the relevant tests.
Created #24 to add support for this.

@kaklakariada kaklakariada self-assigned this Oct 6, 2021
@kaklakariada
Copy link
Collaborator

kaklakariada commented Oct 7, 2021 •
edited
Loading

Test results

  • Instance: t2.xlarge
  • OS: Windows Server 2019
  • Tableau 2021.3

JDBC

Test Count: 921 tests
        Passed tests: 921
        Failed tests: 0
        Tests run: 921
        Disabled tests: 0
        Skipped tests: 0

Other information:
        Smoke test time: 15.22 seconds
        Main test time: 99.88 seconds
        Total time: 115.1 seconds

ODBC

Test Count: 921 tests
        Passed tests: 919
        Failed tests: 2
        Tests run: 921
        Disabled tests: 0
        Skipped tests: 0

Other information:
        Smoke test time: 6.01 seconds
        Main test time: 60.01 seconds
        Total time: 66.02 seconds

kaklakariada added a commit that referenced this issue Oct 22, 2021
@kaklakariada
#22 Implement review findings by @AnastasiiaSergienko
b2078c0
kaklakariada added a commit that referenced this issue Oct 27, 2021
@kaklakariada @AnastasiiaSergienko
Feature/22-switch-to-jdbc-driver (#23)
3230c37 
* Update name of ODBC driver

* Update ODBC manifest

* Add JDBC connector

* Add JDBC capabilities

* Describe installation of jdbc driver

* Adapt capabilities for jdbc driver

* Add fingerprint

* Configure tdvt

* Add data source tests

* Add results workbook

* Update data source

* Update test result workbook

* Configure string trim for jdbc

* Add test with bad password

* Skip string.split test: function not supported by Exasol

* Rename column zzz2 to zzz

* Remove trailing spaces when extracting parts of a date

* Remove duplicate space

* Add rationale for skipping the 'split' function tests

* Change test user name to be equal to odbc tests

* Skip test for time data type

TIME not supported by Exasol

* Rename tdvt folder to odbc

* Adapt hostname for jdbc tests

* Adapt odbc tests to run

* Unify test configuration for jdbc & odbc

* Fix odbc issues with spaces

Remove trimming capabilities that hide issue with trailing spaces in TO_CHAR()

* Configure max number of threads to 1

* Remvove argument for number of threads

This is now configured in the ini file

* Add comment about failing tests

* Ignore Eclipse config files

* Update instructions for building the dockerfile

* Update dependencies

* Improve formatting of readme

* Add HtmlUnit driver

* Use Exasol 7.1.1, improve error handling

* Improve error handling in shell script

* Cleanup

* Adapt configuration to Eclipse 2021-09

* Validate & package jdbc connector

* Improve pom setup

* Cleanup tests: remove unused ports

* Read properties file in Java code to avoid having to set environment
variables when running tests from the IDE.

* Upgrade testcontainers to fix uploading files to the container

user id 'xxx' is too big ( > 2097151 ) when using commons-compress 1.21
with large user ID

testcontainers/testcontainers-java#4384

* Adapt UI-Tests to new Connector name / Tableau version

* Run tests in headless mode

* Document ui-test setup

* Build JDBC url with fingerprint and certificate validation arguments

* Update fingerprint in connection files

* Add developer guide

* Move test instructions to developer guide

* Add connection dialog screenshot

* Configure Eclipse formatter to never join already wrapped lines

* Extract base class for JDBC & ODBC connector tests

* Add UI tests for JDBC connector

* Fix failing StaplesDataTest

See tableau/connector-plugin-sdk#871 for details.

* Add changelog, improve documentation

* #22 Implement review findings by @AnastasiiaSergienko

* Apply suggestions from code review

Co-authored-by: Anastasiia Sergienko <[email protected]>

* Implement review findings by @AnastasiiaSergienko

Co-authored-by: Anastasiia Sergienko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/22-switch-to-jdbc-driver exasol/tableau-connector
2 participants
@redcatbear @kaklakariada