Feature/22-switch-to-jdbc-driver #23

kaklakariada · 2021-10-01T16:55:37Z

Closes #22

-DDisableVerifyConnectorPluginSignature is not required when using -DConnectPluginsPath

TIME not supported by Exasol

Remove trimming capabilities that hide issue with trailing spaces in TO_CHAR()

This is now configured in the ini file

variables when running tests from the IDE.

user id 'xxx' is too big ( > 2097151 ) when using commons-compress 1.21 with large user ID testcontainers/testcontainers-java#4384

See tableau/connector-plugin-sdk#871 for details.

README.md

doc/developer_guide/developer_guide.md

src/exasol_jdbc/connectionBuilder.js

tableau-server-GUI-tests/set_up_scripts/Dockerfile

doc/developer_guide/developer_guide.md

tableau-server-GUI-tests/src/test/java/com/exasol/tableau/JdbcConnectorIT.java

AnastasiiaSergienko · 2021-10-27T10:11:44Z

tableau-server-GUI-tests/src/test/java/com/exasol/tableau/TableauServerGUIGateway.java

@@ -180,7 +193,7 @@ public void openSchema(final String schemaName) {
        final WebElement button = this.getElement("button", "data-tb-test-id", "dataTab-schema-selector-Dropdown", 5);
        this.explicitWait(3);
        button.click();
-        final List<WebElement> schemas = this.getElements("span", "class", "frvoegc");
+        final List<WebElement> schemas = this.getElements("span", "class", "ftmd0dp");


I think we should find a more stable way to reach this element, it will be different in each version. Does it have some other identifier?

I didn't find a better solution in short time. I created issue #28 to refactor this.

tableau-server-GUI-tests/src/test/java/com/exasol/tableau/TableauServerSetUp.java

AnastasiiaSergienko · 2021-10-27T10:28:00Z

tdvt_jdbc/TDVT Results.twb

@@ -0,0 +1,4579 @@
+<?xml version='1.0' encoding='utf-8' ?>


Do we need this file here? This is generated with TDVT tests, right? Maybe remove the file

This workbook is used for viewing the TDVT test results from the csv file. It makes viewing the results much easier.

AnastasiiaSergienko · 2021-10-27T10:30:18Z

tdvt_jdbc/tds/Staples.exasol_jdbc.tds

@@ -0,0 +1,775 @@
+<?xml version='1.0' encoding='utf-8' ?>


Is this file needed?

Yes. The .tds files define the DB connection (host, port, user) and schema used by the TDVT tests.

AnastasiiaSergienko · 2021-10-27T10:30:57Z

tdvt_jdbc/tds/cast_calcs.exasol_jdbc.tds

@@ -0,0 +1,432 @@
+<?xml version='1.0' encoding='utf-8' ?>
+
+<!-- build 20213.21.0917.1006                               -->


Same as above. Required by TDVT tests.

AnastasiiaSergienko · 2021-10-27T10:32:00Z

tdvt_jdbc/test_metadata.csv

@@ -0,0 +1,1093 @@
+Test Category	Test Path Categorized	Test Name Categorized	Function Categorized	Priority


Do we need this? We didn't have one for odbc

This is required as input by the TDVT Results.twb workbook to show the test result report.

AnastasiiaSergienko · 2021-10-27T10:32:43Z

tdvt_odbc/TDVT Results.twb

@@ -0,0 +1,4579 @@
+<?xml version='1.0' encoding='utf-8' ?>
+
+<!-- build 20213.21.0917.1006                               -->


Can we remove it?

Same as before. I find it useful for viewing the test result report.

Co-authored-by: Anastasiia Sergienko <[email protected]>

…/exasol/tableau-connector into feature/22-switch-to-jdbc-driver

AnastasiiaSergienko

Approved!

kaklakariada added 30 commits October 1, 2021 16:09

Update name of ODBC driver

5fef2c5

Update ODBC manifest

4d5f4b0

Add JDBC connector

3f08dc0

Update user guide

2a77ab7

-DDisableVerifyConnectorPluginSignature is not required when using -DConnectPluginsPath

Add JDBC capabilities

f2a96bd

Describe installation of jdbc driver

61da07f

Adapt capabilities for jdbc driver

8005259

Adapt to Exasol

d18e9b4

Add fingerprint

aa3f58a

Configure tdvt

007584c

Add data source tests

62693d0

Add results workbook

888ddc8

Update data source

93e86f6

Update test result workbook

5468ffa

Configure string trim for jdbc

66743d6

Add test with bad password

55b6ef5

Skip string.split test: function not supported by Exasol

0d8a196

Rename column zzz2 to zzz

6df6dc1

Remove trailing spaces when extracting parts of a date

3bd6385

Remove duplicate space

f91f9db

Add rationale for skipping the 'split' function tests

a4b871c

Change test user name to be equal to odbc tests

d99ab28

Skip test for time data type

94b2e8f

TIME not supported by Exasol

Rename tdvt folder to odbc

7824508

Adapt hostname for jdbc tests

a46dd8c

Adapt odbc tests to run

4893e9c

Unify test configuration for jdbc & odbc

b69604c

Fix odbc issues with spaces

816e211

Remove trimming capabilities that hide issue with trailing spaces in TO_CHAR()

Configure max number of threads to 1

31ac6e6

Remvove argument for number of threads

d33dbc5

This is now configured in the ini file

kaklakariada added 16 commits October 20, 2021 04:21

Improve pom setup

f7a9a80

Cleanup tests: remove unused ports

9049e72

Read properties file in Java code to avoid having to set environment

5949a72

variables when running tests from the IDE.

Upgrade testcontainers to fix uploading files to the container

b6f746e

user id 'xxx' is too big ( > 2097151 ) when using commons-compress 1.21 with large user ID testcontainers/testcontainers-java#4384

Adapt UI-Tests to new Connector name / Tableau version

3675255

Run tests in headless mode

5e447c8

Document ui-test setup

a5d4996

Build JDBC url with fingerprint and certificate validation arguments

7a824a7

Update fingerprint in connection files

0279193

Add developer guide

d54a0d1

Move test instructions to developer guide

8f089ad

Add connection dialog screenshot

16c24aa

Configure Eclipse formatter to never join already wrapped lines

5bcd40b

Extract base class for JDBC & ODBC connector tests

d17af39

Add UI tests for JDBC connector

7212df1

Fix failing StaplesDataTest

ac3afbe

See tableau/connector-plugin-sdk#871 for details.

kaklakariada self-assigned this Oct 22, 2021

kaklakariada added feature Product feature source:exasol labels Oct 22, 2021

kaklakariada requested a review from AnastasiiaSergienko October 22, 2021 07:47

Add changelog, improve documentation

45de930

AnastasiiaSergienko reviewed Oct 22, 2021

View reviewed changes

#22 Implement review findings by @AnastasiiaSergienko

b2078c0

AnastasiiaSergienko reviewed Oct 27, 2021

View reviewed changes

kaklakariada and others added 3 commits October 27, 2021 13:32

Apply suggestions from code review

666f431

Co-authored-by: Anastasiia Sergienko <[email protected]>

Implement review findings by @AnastasiiaSergienko

4cd944a

Merge branch 'feature/22-switch-to-jdbc-driver' of https://github.com…

559a0a8

…/exasol/tableau-connector into feature/22-switch-to-jdbc-driver

AnastasiiaSergienko approved these changes Oct 27, 2021

View reviewed changes

kaklakariada merged commit 3230c37 into main Oct 27, 2021

kaklakariada deleted the feature/22-switch-to-jdbc-driver branch October 27, 2021 14:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/22-switch-to-jdbc-driver #23

Feature/22-switch-to-jdbc-driver #23

kaklakariada commented Oct 1, 2021

AnastasiiaSergienko Oct 27, 2021

kaklakariada Oct 27, 2021

AnastasiiaSergienko Oct 27, 2021

kaklakariada Oct 27, 2021

AnastasiiaSergienko Oct 27, 2021

kaklakariada Oct 27, 2021

AnastasiiaSergienko Oct 27, 2021

kaklakariada Oct 27, 2021

AnastasiiaSergienko Oct 27, 2021

kaklakariada Oct 27, 2021

AnastasiiaSergienko Oct 27, 2021

kaklakariada Oct 27, 2021

AnastasiiaSergienko left a comment

		@@ -0,0 +1,432 @@
		<?xml version='1.0' encoding='utf-8' ?>

		<!-- build 20213.21.0917.1006 -->

		@@ -0,0 +1,1093 @@
		Test Category Test Path Categorized Test Name Categorized Function Categorized Priority

		@@ -0,0 +1,4579 @@
		<?xml version='1.0' encoding='utf-8' ?>

		<!-- build 20213.21.0917.1006 -->

Feature/22-switch-to-jdbc-driver #23

Feature/22-switch-to-jdbc-driver #23

Conversation

kaklakariada commented Oct 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnastasiiaSergienko left a comment

Choose a reason for hiding this comment