Toggleable orthographic camera added. #1098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve versioning display with `--version`
* fix cppcheck * another cppcheck fix * try again
* Add soname to shared library
Update CMakelists to add soname to shared library
using VERSION ${F3D_MAJOR_VERSION}.${F3D_MINOR_VERSION} and SOVERSION ${F3D_MAJOR_VERSION}
Add F3D_PLUGINS_INSTALL_DIR option
* Add a drop zone - Add a new dynamic vtkF3DDropZoneActor (co-author: @snoyer ) - Show the dropzone when no file are loaded - Remove previous behavior of showing information in the filename info - Add a test
When no mapper is set vtkActor2D is erroring in the default impl of rendering methods. Override them to avoid that.
…ile (f3d-app#831) * Fix an issue with window not reset when loading another file
* Camera: Reset using screenspace
…3d-app#832) * Add F3D_USE_EXTERNAL_DEPS option for third party libraries * Use options F3D_USE_EXTERNAL_CXXOPTS and F3D_USE_EXTERNAL_NLOHMANN_JSON instead * fix cppcheck * explicitly specify the include directories * fix * fix typo * add find_package to toplevel CMakeLists.txt file * fix for codespell
* Add `--camera-direction` option * Add `--camera-zoom-factor` option (need vtk 9.3) * Use `camera-direction` in default config file for better default camera direction (open to changes on this one) * Fix f3d-app#45
Co-authored-by: snoyer <[email protected]>
## Changes * Updated `.gitignore` to include `build` directories, `.vs` directories (for visual studio) and `CMakeUserPresets.json` * New option to invert zoom when using right mouse button + drag * Added support for zooming in/out with either vertical or horizontal drag when holding right mouse button * Added interaction unit test for invert zoom feature Fixes f3d-app#280
## Rework animation suport - Rely on real elapsed time instead of timestep to animate - Store animationManager in loader instead of interactor - Add an --animation-speed-factor option to slow, speed and invert time\ - Add an --animation-time option to set an animation time to load - Add an --animation-frame-rate option to control animation frame rate - Fix multiple issues related to time and improve internal doc - update tests accordingly - Add doc for options and animations
- Update VTK version in CI and packaging - Update baseline for VRML - Switch to TBB for CI and update suppressions accordingly
- Move initialization logic from a global logic to an instance logic - Remove a few useless `f3d::`
- Add simple support for dropping HDRI by pressing Ctrl while dropping - Fix f3d-app#34 - Fix an issue when options are changed before a file is loaded and add a test - Ctrl pressed down cannot be tested - Update Doc and dropzone
|
You are modifying libf3d public API! |
mwestphal
reviewed
Dec 12, 2023
mwestphal
reviewed
Dec 12, 2023
|
Any consensus on "orthographic" vs "orthogonal" vs "parallel" to name the projection within the app/UI? Wikipedia says "Orthographic projection (also orthogonal projection and analemma) [...] is a form of parallel projection" and has a nice illustration which is very educational but doesn't solve the choice. |
|
I vote for Orthographic. |
Added tests.
Added a changelog for orthographic projection.
mwestphal
requested changes
Dec 15, 2023
Meakk
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Here's the list of failing tests. They are all related to the cheatsheet, and it makes sense. Please update the baselines.
The following tests FAILED:
165 - f3d::TestInteractionCheatsheetRaytracing (Failed)
166 - f3d::TestInteractionCheatsheetWhiteBGRaytracing (Failed)
167 - f3d::TestInteractionCheatsheetBlackBGRaytracing (Failed)
168 - f3d::TestInteractionCheatsheetScalarsRaytracing (Failed)
169 - f3d::TestInteractionNoFileCheatsheetRaytracing (Failed)
Errors while running CTest
|
Just in case you need the new baselines |
|
@aemreaydin please "resolve" discussion that you have adressed :) |
|
You need to rebase again. I would suggest to add changelog right before mergingn to avoid this :) |
|
Hi @aemreaydin , need any help moving forward ? |
|
Hi @aemreaydin , please let us know if you still want to work on this :) |
mwestphal
force-pushed
the
master
branch
4 times, most recently
from
a8aac1c to
3f8eb1d
Compare
|
superseeded by #1235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #17 #1096